| John Kordich via Review Board |
Re: Review Request 66014: Windows: Made SASL use default CRT linking. |
Fri, 09 Mar, 23:17 |
| Chun-Hung Hsiao |
Re: Review Request 65666: Added a unit test for SLRP operation state metrics. |
Fri, 09 Mar, 23:29 |
| Jie Yu |
Re: Review Request 65987: Allow nested containers in pods to have separate namespaces(Ref: MESOS-8534). |
Fri, 09 Mar, 23:40 |
| Mesos Reviewbot Windows |
Re: Review Request 66014: Windows: Made SASL use default CRT linking. |
Fri, 09 Mar, 23:43 |
| Mesos Reviewbot |
Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution. |
Fri, 09 Mar, 23:55 |
| Meng Zhu |
Review Request 66016: Refactored resource allocation logic. |
Sat, 10 Mar, 00:44 |
| Mesos Reviewbot Windows |
Re: Review Request 65666: Added a unit test for SLRP operation state metrics. |
Sat, 10 Mar, 00:46 |
| Benjamin Mahler |
Review Request 66004: Updated task reconciliation path to avoid copying in v1. |
Sat, 10 Mar, 00:51 |
| Benjamin Mahler |
Re: Review Request 65334: Added quota limit to the master API protos. |
Sat, 10 Mar, 01:46 |
| Benjamin Mahler |
Re: Review Request 65851: Disallow limit in /quota requests and SET_QUOTA calls. |
Sat, 10 Mar, 01:46 |
| Mesos Reviewbot Windows |
Re: Review Request 66016: Refactored resource allocation logic. |
Sat, 10 Mar, 01:49 |
| Mesos Reviewbot Windows |
Re: Review Request 66004: Updated task reconciliation path to avoid copying in v1. |
Sat, 10 Mar, 02:52 |
| Benjamin Bannier |
Re: Review Request 65906: Updated site's middleman to latest 3.x release. |
Sat, 10 Mar, 17:49 |
| Benjamin Bannier |
Review Request 66022: Based website-related Docker images on ubuntu16. |
Sat, 10 Mar, 17:49 |
| Mesos Reviewbot Windows |
Re: Review Request 65906: Updated site's middleman to latest 3.x release. |
Sat, 10 Mar, 18:53 |
| Mesos Reviewbot |
Re: Review Request 66002: Fixed the HTTP API path variables on Windows. |
Sat, 10 Mar, 20:10 |
| Mesos Reviewbot Windows |
Re: Review Request 66016: Refactored resource allocation logic. |
Sat, 10 Mar, 21:37 |
| Mesos Reviewbot |
Re: Review Request 66014: Windows: Made SASL use default CRT linking. |
Sat, 10 Mar, 22:30 |
| Mesos Reviewbot |
Re: Review Request 66004: Updated task reconciliation path to avoid copying in v1. |
Sun, 11 Mar, 02:55 |
| Mesos Reviewbot |
Re: Review Request 65906: Updated site's middleman to latest 3.x release. |
Sun, 11 Mar, 05:20 |
| Mesos Reviewbot |
Re: Review Request 66016: Refactored resource allocation logic. |
Sun, 11 Mar, 07:40 |
| Armand Grillet |
Re: Review Request 66022: Based website-related Docker images on ubuntu16. |
Sun, 11 Mar, 09:06 |
| Armand Grillet |
Re: Review Request 65906: Updated site's middleman to latest 3.x release. |
Sun, 11 Mar, 09:16 |
| Armand Grillet |
Re: Review Request 65906: Updated site's middleman to latest 3.x release. |
Sun, 11 Mar, 09:16 |
| Qian Zhang |
Review Request 66025: Converted `JSON::String` to bool and integers. |
Mon, 12 Mar, 01:27 |
| Qian Zhang |
Re: Review Request 66025: Converted `JSON::String` to bool and integers. |
Mon, 12 Mar, 01:28 |
| Qian Zhang |
Review Request 66026: Updated `ProtobufTest.JSON` for parsing JSON::String to bools&integers. |
Mon, 12 Mar, 01:30 |
| Mesos Reviewbot Windows |
Re: Review Request 66026: Updated `ProtobufTest.JSON` for parsing JSON::String to bools&integers. |
Mon, 12 Mar, 02:36 |
| Mesos Reviewbot |
Re: Review Request 66026: Updated `ProtobufTest.JSON` for parsing JSON::String to bools&integers. |
Mon, 12 Mar, 03:29 |
| Qian Zhang |
Re: Review Request 59987: Added protobuf map support to stout JSON<->protobuf conversion. |
Mon, 12 Mar, 07:15 |
| Qian Zhang |
Re: Review Request 59987: Added protobuf map support to stout JSON<->protobuf conversion. |
Mon, 12 Mar, 07:18 |
| Harold Dost |
Re: Review Request 66000: Update enforce_container_disk_quota documentation to include disk/xfs. |
Mon, 12 Mar, 08:28 |
| Mesos Reviewbot Windows |
Re: Review Request 66000: Update enforce_container_disk_quota documentation to include disk/xfs. |
Mon, 12 Mar, 09:33 |
| Mesos Reviewbot Windows |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Mon, 12 Mar, 10:23 |
| Benjamin Bannier |
Re: Review Request 65591: Explicitly tracked resource providers in master. |
Mon, 12 Mar, 10:44 |
| Alexander Rukletsov |
Re: Review Request 66022: Based website-related Docker images on ubuntu16. |
Mon, 12 Mar, 11:51 |
| Alexander Rukletsov |
Re: Review Request 65906: Updated site's middleman to latest 3.x release. |
Mon, 12 Mar, 11:56 |
| Mesos Reviewbot |
Re: Review Request 66000: Update enforce_container_disk_quota documentation to include disk/xfs. |
Mon, 12 Mar, 12:27 |
| Benjamin Bannier |
Re: Review Request 66022: Based website-related Docker images on ubuntu16. |
Mon, 12 Mar, 13:29 |
| Benjamin Bannier |
Re: Review Request 66022: Based website-related Docker images on ubuntu16. |
Mon, 12 Mar, 13:44 |
| Mesos Reviewbot |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Mon, 12 Mar, 13:49 |
| Alexander Rojas |
Re: Review Request 65314: Removed code which is not used. |
Mon, 12 Mar, 14:05 |
| Alexander Rojas |
Re: Review Request 65311: Added the ObjectApprovers to which unifies authorization logic. |
Mon, 12 Mar, 14:08 |
| Mesos Reviewbot Windows |
Re: Review Request 65350: Modified `cgroups::prepare` to check nested cgroups support only once. |
Mon, 12 Mar, 14:30 |
| Mesos Reviewbot |
Re: Review Request 65350: Modified `cgroups::prepare` to check nested cgroups support only once. |
Mon, 12 Mar, 16:40 |
| John Kordich via Review Board |
Re: Review Request 66007: CMake: Set C++11 as standard automatically. |
Mon, 12 Mar, 17:33 |
| John Kordich via Review Board |
Re: Review Request 66009: CMake: Added `-Wno-unused-local-typedefs` to Boost interface. |
Mon, 12 Mar, 17:33 |
| John Kordich via Review Board |
Re: Review Request 66010: Windows: Switched to default CRT linkage. |
Mon, 12 Mar, 17:35 |
| John Kordich via Review Board |
Re: Review Request 66013: Windows: Made ZooKeeper use default CRT linking. |
Mon, 12 Mar, 17:41 |
| John Kordich via Review Board |
Re: Review Request 66011: Windows: Set 3rdparty libraries to link to CRT dynamically. |
Mon, 12 Mar, 17:42 |
| John Kordich via Review Board |
Re: Review Request 66012: CMake: Split `CMAKE_FORWARD_ARGS` into `C` and `CXX` versions. |
Mon, 12 Mar, 17:50 |
| Greg Mann |
Re: Review Request 65995: Declined unwanted offers in `RetryOperationStatusUpdate*` SLRP tests. |
Mon, 12 Mar, 18:44 |
| Greg Mann |
Review Request 65879: Added a new test for validation of offer operation IDs. |
Mon, 12 Mar, 19:26 |
| Greg Mann |
Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler. |
Mon, 12 Mar, 19:32 |
| Benjamin Mahler |
Re: Review Request 66025: Converted `JSON::String` to bool and integers. |
Mon, 12 Mar, 21:53 |
| Benjamin Mahler |
Re: Review Request 66016: Refactored resource allocation logic. |
Mon, 12 Mar, 22:29 |
| Meng Zhu |
Re: Review Request 66016: Refactored resource allocation logic. |
Mon, 12 Mar, 23:08 |
| Meng Zhu |
Re: Review Request 66016: Refactored resource allocation logic. |
Mon, 12 Mar, 23:08 |
| Ilya Pronin |
Review Request 66030: Fixed perf stat output parsing. |
Tue, 13 Mar, 00:03 |
| Benjamin Mahler |
Review Request 66031: Avoided copying when possible in Option::getOrElse. |
Tue, 13 Mar, 00:08 |
| Michael Park |
Re: Review Request 66031: Avoided copying when possible in Option::getOrElse. |
Tue, 13 Mar, 00:10 |
| Benjamin Mahler |
Re: Review Request 66016: Refactored resource allocation logic. |
Tue, 13 Mar, 00:12 |
| Mesos Reviewbot Windows |
Re: Review Request 66016: Refactored resource allocation logic. |
Tue, 13 Mar, 00:14 |
| Sagar Patwardhan |
Re: Review Request 65987: Allow nested containers in pods to have separate namespaces(Ref: MESOS-8534). |
Tue, 13 Mar, 00:44 |
| Chun-Hung Hsiao |
Re: Review Request 66025: Converted `JSON::String` to bool and integers. |
Tue, 13 Mar, 01:22 |
| Mesos Reviewbot Windows |
Re: Review Request 66030: Fixed perf stat output parsing. |
Tue, 13 Mar, 01:22 |
| Jason Lai |
Review Request 66034: Remount several proc filesystem entries as read-only. |
Tue, 13 Mar, 01:26 |
| Jason Lai |
Re: Review Request 66034: Remount several proc filesystem entries as read-only. |
Tue, 13 Mar, 01:29 |
| Chun-Hung Hsiao |
Re: Review Request 66026: Updated `ProtobufTest.JSON` for parsing JSON::String to bools&integers. |
Tue, 13 Mar, 01:41 |
| Chun-Hung Hsiao |
Re: Review Request 59987: Added protobuf map support to stout JSON<->protobuf conversion. |
Tue, 13 Mar, 02:07 |
| Gilbert Song |
Re: Review Request 65915: Validated Docker info exists when container's type is DOCKER. |
Tue, 13 Mar, 02:22 |
| Gilbert Song |
Re: Review Request 65916: Set Docker info for the test `TaskUsesDockerContainerInfo`. |
Tue, 13 Mar, 02:23 |
| Mesos Reviewbot |
Re: Review Request 66030: Fixed perf stat output parsing. |
Tue, 13 Mar, 02:29 |
| Mesos Reviewbot Windows |
Re: Review Request 66034: Remount several proc filesystem entries as read-only. |
Tue, 13 Mar, 02:38 |
| Gilbert Song |
Re: Review Request 65917: Added a test `TaskValidationTest.TaskMissingDockerInfo`. |
Tue, 13 Mar, 02:50 |
| Gilbert Song |
Re: Review Request 65918: Made sure no `name` parameter exists in container's Docker info. |
Tue, 13 Mar, 02:52 |
| Gilbert Song |
Re: Review Request 65919: Added a test `TaskValidationTest.TaskSettingDockerContainerName`. |
Tue, 13 Mar, 02:53 |
| Gilbert Song |
Re: Review Request 65919: Added a test `TaskValidationTest.TaskSettingDockerContainerName`. |
Tue, 13 Mar, 03:02 |
| Mesos Reviewbot Windows |
Re: Review Request 65994: Made the master forward operation status updates to the schedulers. |
Tue, 13 Mar, 03:46 |
| Mesos Reviewbot |
Re: Review Request 66034: Remount several proc filesystem entries as read-only. |
Tue, 13 Mar, 06:02 |
| Benjamin Peterson |
Re: Review Request 65886: Do not realpath executables from launcher_dir. |
Tue, 13 Mar, 06:33 |
| Qian Zhang |
Re: Review Request 66025: Converted `JSON::String` to bool and integers. |
Tue, 13 Mar, 06:47 |
| Qian Zhang |
Re: Review Request 66025: Converted `JSON::String` to bool and integers. |
Tue, 13 Mar, 06:47 |
| Qian Zhang |
Re: Review Request 66025: Converted `JSON::String` to bool and numbers. |
Tue, 13 Mar, 06:48 |
| Qian Zhang |
Re: Review Request 66026: Updated `ProtobufTest.JSON` for parsing JSON::String to bools&integers. |
Tue, 13 Mar, 07:08 |
| Qian Zhang |
Re: Review Request 66026: Updated `ProtobufTest.JSON` for parsing JSON::String to bools & numbers. |
Tue, 13 Mar, 07:09 |
| Qian Zhang |
Re: Review Request 59987: Added protobuf map support to stout JSON<->protobuf conversion. |
Tue, 13 Mar, 09:13 |
| Qian Zhang |
Re: Review Request 59987: Added protobuf map support to stout JSON<->protobuf conversion. |
Tue, 13 Mar, 09:13 |
| Mesos Reviewbot |
Re: Review Request 65994: Made the master forward operation status updates to the schedulers. |
Tue, 13 Mar, 09:35 |
| Benjamin Bannier |
Review Request 66035: Updated mesos-tidy setup to be based on upstream 6.0 release. |
Tue, 13 Mar, 09:49 |
| Mesos Reviewbot Windows |
Re: Review Request 66035: Updated mesos-tidy setup to be based on upstream 6.0 release. |
Tue, 13 Mar, 10:57 |
| Mesos Reviewbot |
Re: Review Request 66035: Updated mesos-tidy setup to be based on upstream 6.0 release. |
Tue, 13 Mar, 12:27 |
| fei long |
Review Request 66038: Add usageWithInode to check both disk and inode usage. |
Tue, 13 Mar, 13:05 |
| fei long |
Review Request 66039: Check both disk and inode usage when slaves schedule gc. |
Tue, 13 Mar, 13:05 |
| Mesos Reviewbot Windows |
Re: Review Request 66039: Check both disk and inode usage when slaves schedule gc. |
Tue, 13 Mar, 13:38 |
| Mesos Reviewbot |
Re: Review Request 66039: Check both disk and inode usage when slaves schedule gc. |
Tue, 13 Mar, 13:40 |
| Harold Dost |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Tue, 13 Mar, 13:45 |
| fei long |
Re: Review Request 66039: Check both disk and inode usage when slaves schedule gc. |
Tue, 13 Mar, 14:05 |
| fei long |
Re: Review Request 66038: Add usageWithInode to check both disk and inode usage. |
Tue, 13 Mar, 14:08 |
| Mesos Reviewbot Windows |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Tue, 13 Mar, 14:56 |