| Benjamin Mahler |
Review Request 65966: Updated the master's receive handler to take an rvalue reference. |
Thu, 08 Mar, 03:52 |
| Benjamin Mahler |
Review Request 65967: Eliminated some copying in the master's Accept call handler path. |
Thu, 08 Mar, 03:52 |
| Benjamin Mahler |
Review Request 65968: Updated the master's decline handler to take an rvalue reference. |
Thu, 08 Mar, 03:52 |
| Mesos Reviewbot |
Re: Review Request 65959: Added a test to make sure `slave/recovery_secs` is reported in metrics. |
Thu, 08 Mar, 04:22 |
| Greg Mann |
Re: Review Request 65311: Added the ObjectApprovers to which unifies authorization logic. |
Thu, 08 Mar, 04:24 |
| Benjamin Mahler |
Review Request 65969: Avoid a copy of the status update acknowledgements in the master. |
Thu, 08 Mar, 04:24 |
| Benjamin Mahler |
Review Request 65970: Avoid copying acknowledgement message data in the master. |
Thu, 08 Mar, 04:28 |
| Benjamin Mahler |
Review Request 65971: Avoid a copy of the scheduler->executor message in the master. |
Thu, 08 Mar, 04:30 |
| Benjamin Mahler |
Review Request 65972: Avoid copying scheduler->executor message data in the master. |
Thu, 08 Mar, 04:34 |
| Benjamin Mahler |
Review Request 65973: Avoid copying executor->scheduler message data in the master. |
Thu, 08 Mar, 04:36 |
| Chun-Hung Hsiao |
Review Request 65974: Added comments and made some renaming in SLRP. |
Thu, 08 Mar, 04:56 |
| Chun-Hung Hsiao |
Re: Review Request 65594: Checkpointed profiles in storage local resource provider. |
Thu, 08 Mar, 05:04 |
| Chun-Hung Hsiao |
Re: Review Request 65594: Checkpointed profiles in storage local resource provider. |
Thu, 08 Mar, 05:04 |
| Chun-Hung Hsiao |
Review Request 65975: Sequentialize reconciliations of storage pools in SLRP. |
Thu, 08 Mar, 05:05 |
| Chun-Hung Hsiao |
Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`. |
Thu, 08 Mar, 05:05 |
| Mesos Reviewbot Windows |
Re: Review Request 65968: Updated the master's decline handler to take an rvalue reference. |
Thu, 08 Mar, 05:07 |
| Greg Mann |
Re: Review Request 65312: Refactored authorization logic in the master. |
Thu, 08 Mar, 05:07 |
| Mesos Reviewbot Windows |
Re: Review Request 65973: Avoid copying executor->scheduler message data in the master. |
Thu, 08 Mar, 06:10 |
| Mesos Reviewbot |
Re: Review Request 65962: Made the default executor use references to `Owned<Container>` pointers. |
Thu, 08 Mar, 06:58 |
| Benjamin Bannier |
Re: Review Request 65962: Made the default executor use references to `Owned<Container>` pointers. |
Thu, 08 Mar, 07:13 |
| Benjamin Bannier |
Re: Review Request 65692: Changed the signature of a DefaultExecutor kill method. |
Thu, 08 Mar, 07:13 |
| Mesos Reviewbot |
Re: Review Request 65973: Avoid copying executor->scheduler message data in the master. |
Thu, 08 Mar, 09:27 |
| Alexander Rojas |
Re: Review Request 65311: Added the ObjectApprovers to which unifies authorization logic. |
Thu, 08 Mar, 10:53 |
| Alexander Rojas |
Re: Review Request 65310: Added lambda::zip. |
Thu, 08 Mar, 12:10 |
| Alexander Rojas |
Re: Review Request 65311: Added the ObjectApprovers to which unifies authorization logic. |
Thu, 08 Mar, 12:14 |
| Alexander Rojas |
Re: Review Request 65312: Refactored authorization logic in the master. |
Thu, 08 Mar, 12:25 |
| Alexander Rojas |
Re: Review Request 65313: Refactored authorization logic in the agent. |
Thu, 08 Mar, 12:26 |
| Alexander Rojas |
Re: Review Request 65314: Removed code which is not used. |
Thu, 08 Mar, 12:26 |
| Mesos Reviewbot |
Re: Review Request 65314: Removed code which is not used. |
Thu, 08 Mar, 13:26 |
| Mesos Reviewbot Windows |
Re: Review Request 65314: Removed code which is not used. |
Thu, 08 Mar, 13:32 |
| Sagar Patwardhan |
Review Request 65987: Allow nested containers in pods to have separate namespaces(Ref: MESOS-8534). |
Thu, 08 Mar, 17:07 |
| Mesos Reviewbot Windows |
Re: Review Request 65987: Allow nested containers in pods to have separate namespaces(Ref: MESOS-8534). |
Thu, 08 Mar, 17:59 |
| Meng Zhu |
Re: Review Request 65973: Avoid copying executor->scheduler message data in the master. |
Thu, 08 Mar, 18:48 |
| John Kordich via Review Board |
Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution. |
Thu, 08 Mar, 19:22 |
| Jeff Coffler |
Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution. |
Thu, 08 Mar, 19:46 |
| Meng Zhu |
Re: Review Request 65967: Eliminated some copying in the master's Accept call handler path. |
Thu, 08 Mar, 20:09 |
| Mesos Reviewbot Windows |
Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution. |
Thu, 08 Mar, 20:20 |
| Meng Zhu |
Re: Review Request 65968: Updated the master's decline handler to take an rvalue reference. |
Thu, 08 Mar, 20:54 |
| Andrew Schwartzmeyer |
Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution. |
Thu, 08 Mar, 21:12 |
| Jiang Yan Xu |
Re: Review Request 65967: Eliminated some copying in the master's Accept call handler path. |
Thu, 08 Mar, 21:16 |
| Gaston Kleiman |
Re: Review Request 65962: Avoided copying `Owned` pointers in the default executor. |
Thu, 08 Mar, 22:00 |
| Gaston Kleiman |
Review Request 65993: Added evolve functions for operation status updates. |
Thu, 08 Mar, 22:06 |
| Gaston Kleiman |
Review Request 65994: Made the master forward operation status updates to the schedulers. |
Thu, 08 Mar, 22:07 |
| Mesos Reviewbot Windows |
Re: Review Request 65962: Avoided copying `Owned` pointers in the default executor. |
Thu, 08 Mar, 23:06 |
| John Kordich via Review Board |
Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution. |
Thu, 08 Mar, 23:21 |
| Chun-Hung Hsiao |
Review Request 65995: Declined unwanted offers in `RetryOperationStatusUpdate*` SLRP tests. |
Thu, 08 Mar, 23:39 |
| Chun-Hung Hsiao |
Re: Review Request 65975: Sequentialize reconciliations of storage pools in SLRP. |
Thu, 08 Mar, 23:41 |
| Andrew Schwartzmeyer |
Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution. |
Thu, 08 Mar, 23:54 |
| Gaston Kleiman |
Re: Review Request 65995: Declined unwanted offers in `RetryOperationStatusUpdate*` SLRP tests. |
Fri, 09 Mar, 00:56 |
| Mesos Reviewbot Windows |
Re: Review Request 65994: Made the master forward operation status updates to the schedulers. |
Fri, 09 Mar, 01:03 |
| Mesos Reviewbot Windows |
Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution. |
Fri, 09 Mar, 01:03 |
| Chun-Hung Hsiao |
Re: Review Request 65594: Checkpointed profiles in storage local resource provider. |
Fri, 09 Mar, 01:29 |
| Chun-Hung Hsiao |
Re: Review Request 65594: Checkpointed profiles in storage local resource provider. |
Fri, 09 Mar, 01:29 |
| Chun-Hung Hsiao |
Re: Review Request 65594: Checkpointed profiles in storage local resource provider. |
Fri, 09 Mar, 01:38 |
| Greg Mann |
Re: Review Request 65313: Refactored authorization logic in the agent. |
Fri, 09 Mar, 05:30 |
| Alexander Rojas |
Re: Review Request 65313: Refactored authorization logic in the agent. |
Fri, 09 Mar, 12:11 |
| Alexander Rojas |
Re: Review Request 65313: Refactored authorization logic in the agent. |
Fri, 09 Mar, 13:06 |
| Mesos Reviewbot |
Re: Review Request 65987: Allow nested containers in pods to have separate namespaces(Ref: MESOS-8534). |
Fri, 09 Mar, 13:21 |
| Qian Zhang |
Re: Review Request 59987: Added protobuf map support to stout JSON<->protobuf conversion. |
Fri, 09 Mar, 13:59 |
| Qian Zhang |
Re: Review Request 59987: Added protobuf map support to stout JSON<->protobuf conversion. |
Fri, 09 Mar, 14:08 |
| Mesos Reviewbot |
Re: Review Request 65962: Avoided copying `Owned` pointers in the default executor. |
Fri, 09 Mar, 15:49 |
| Harold Dost |
Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Fri, 09 Mar, 17:04 |
| Harold Dost |
Review Request 66000: Update enforce_container_disk_quota documentation to include disk/xfs. |
Fri, 09 Mar, 17:04 |
| Meng Zhu |
Re: Review Request 65972: Avoid copying scheduler->executor message data in the master. |
Fri, 09 Mar, 17:44 |
| Mesos Reviewbot Windows |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Fri, 09 Mar, 18:13 |
| Andrew Schwartzmeyer |
Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution. |
Fri, 09 Mar, 18:17 |
| Mesos Reviewbot |
Re: Review Request 65994: Made the master forward operation status updates to the schedulers. |
Fri, 09 Mar, 18:29 |
| Greg Mann |
Re: Review Request 65938: Replaced "re-register" terminology with "reregister". |
Fri, 09 Mar, 18:29 |
| James Peach |
Re: Review Request 65954: Add a gauge for how long agent recovery takes. |
Fri, 09 Mar, 18:53 |
| James Peach |
Re: Review Request 65954: Add a gauge for how long agent recovery takes. |
Fri, 09 Mar, 18:54 |
| John Kordich via Review Board |
Review Request 66002: Fixed the HTTP API path variables on Windows to use proper seperators. |
Fri, 09 Mar, 19:27 |
| John Kordich via Review Board |
Re: Review Request 66002: Fixed the HTTP API path variables on Windows to use proper seperators. |
Fri, 09 Mar, 19:33 |
| Andrew Schwartzmeyer |
Re: Review Request 66002: Fixed the HTTP API path variables on Windows to use proper seperators. |
Fri, 09 Mar, 19:42 |
| Greg Mann |
Re: Review Request 65314: Removed code which is not used. |
Fri, 09 Mar, 19:51 |
| Meng Zhu |
Re: Review Request 65971: Avoid a copy of the scheduler->executor message in the master. |
Fri, 09 Mar, 20:01 |
| Meng Zhu |
Re: Review Request 65970: Avoid copying acknowledgement message data in the master. |
Fri, 09 Mar, 20:10 |
| Meng Zhu |
Re: Review Request 65969: Avoid a copy of the status update acknowledgements in the master. |
Fri, 09 Mar, 20:10 |
| Meng Zhu |
Re: Review Request 65965: Avoid copying of launch task messages in the master. |
Fri, 09 Mar, 20:15 |
| Meng Zhu |
Re: Review Request 65966: Updated the master's receive handler to take an rvalue reference. |
Fri, 09 Mar, 20:15 |
| Meng Zhu |
Re: Review Request 65964: Updated the master's status update handler to avoid unnecessary copying. |
Fri, 09 Mar, 20:17 |
| John Kordich via Review Board |
Re: Review Request 66002: Fixed the HTTP API path variables on Windows. |
Fri, 09 Mar, 20:17 |
| Benjamin Mahler |
Re: Review Request 65967: Eliminated some copying in the master's Accept call handler path. |
Fri, 09 Mar, 20:27 |
| Benjamin Mahler |
Re: Review Request 65968: Updated the master's decline handler to take an rvalue reference. |
Fri, 09 Mar, 20:30 |
| Mesos Reviewbot Windows |
Re: Review Request 66002: Fixed the HTTP API path variables on Windows. |
Fri, 09 Mar, 20:33 |
| Benjamin Mahler |
Re: Review Request 65971: Avoid a copy of the scheduler->executor message in the master. |
Fri, 09 Mar, 20:34 |
| Mesos Reviewbot |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Fri, 09 Mar, 21:20 |
| Greg Mann |
Re: Review Request 65311: Added the ObjectApprovers to which unifies authorization logic. |
Fri, 09 Mar, 21:34 |
| Greg Mann |
Re: Review Request 65313: Refactored authorization logic in the agent. |
Fri, 09 Mar, 22:13 |
| Greg Mann |
Re: Review Request 65311: Added the ObjectApprovers to which unifies authorization logic. |
Fri, 09 Mar, 22:16 |
| Andrew Schwartzmeyer |
Review Request 66007: CMake: Set C++11 as standard automatically. |
Fri, 09 Mar, 22:37 |
| Andrew Schwartzmeyer |
Review Request 66008: CMake: Enabled compiler warnings. |
Fri, 09 Mar, 22:38 |
| Andrew Schwartzmeyer |
Review Request 66009: CMake: Added `-Wno-unused-local-typedefs` to Boost interface. |
Fri, 09 Mar, 22:38 |
| Andrew Schwartzmeyer |
Review Request 66010: Windows: Switched to default CRT linkage. |
Fri, 09 Mar, 22:39 |
| Andrew Schwartzmeyer |
Review Request 66011: Windows: Set 3rdparty libraries to link to CRT dynamically. |
Fri, 09 Mar, 22:39 |
| Andrew Schwartzmeyer |
Review Request 66012: CMake: Split `CMAKE_FORWARD_ARGS` into `C` and `CXX` versions. |
Fri, 09 Mar, 22:39 |
| Andrew Schwartzmeyer |
Review Request 66013: Windows: Made ZooKeeper use default CRT linking. |
Fri, 09 Mar, 22:39 |
| Andrew Schwartzmeyer |
Review Request 66014: Windows: Made SASL use default CRT linking. |
Fri, 09 Mar, 22:39 |
| Chun-Hung Hsiao |
Re: Review Request 65997: Added `PROTOC_SPEC_GENERATE` helper for cmake. |
Fri, 09 Mar, 22:44 |
| Chun-Hung Hsiao |
Review Request 66015: Built CSI spec proto files with cmake. |
Fri, 09 Mar, 22:45 |
| Chun-Hung Hsiao |
Re: Review Request 65665: Added operation state metrics in SLRP. |
Fri, 09 Mar, 22:55 |