| Qian Zhang |
Review Request 66206: Used native protobuf map in Docker v1 image spec. |
Thu, 22 Mar, 06:56 |
| Qian Zhang |
Review Request 66207: Used native protobuf map in OCI v1 image spec. |
Thu, 22 Mar, 06:59 |
| Harold Dost |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Thu, 22 Mar, 07:43 |
| Mesos Reviewbot Windows |
Re: Review Request 66207: Used native protobuf map in OCI v1 image spec. |
Thu, 22 Mar, 08:01 |
| Mesos Reviewbot |
Re: Review Request 66207: Used native protobuf map in OCI v1 image spec. |
Thu, 22 Mar, 09:00 |
| Jan Schlicht |
Re: Review Request 66156: Compiled `csi.proto` when gRPC is disabled. |
Thu, 22 Mar, 09:27 |
| Jan Schlicht |
Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'. |
Thu, 22 Mar, 09:37 |
| Qian Zhang |
Review Request 66211: Added the fields `ExposedPorts` and `Volumes` into Docker v1 image spec. |
Thu, 22 Mar, 09:47 |
| Qian Zhang |
Review Request 66212: Updated `ParseV1ImageManifest` to check `Volumes` and `ExposedPorts`. |
Thu, 22 Mar, 09:47 |
| Jan Schlicht |
Re: Review Request 66163: Built storage local resource provider with CMake. |
Thu, 22 Mar, 10:06 |
| Mesos Reviewbot Windows |
Re: Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'. |
Thu, 22 Mar, 10:39 |
| Mesos Reviewbot Windows |
Re: Review Request 66212: Updated `ParseV1ImageManifest` to check `Volumes` and `ExposedPorts`. |
Thu, 22 Mar, 11:40 |
| Benno Evers |
Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'. |
Thu, 22 Mar, 12:06 |
| Alexander Rukletsov |
Re: Review Request 65962: Avoided copying `Owned` pointers in the default executor. |
Thu, 22 Mar, 13:13 |
| Mesos Reviewbot Windows |
Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'. |
Thu, 22 Mar, 14:00 |
| Alexander Rukletsov |
Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'. |
Thu, 22 Mar, 14:08 |
| Alexander Rukletsov |
Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'. |
Thu, 22 Mar, 14:11 |
| Harold Dost |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Thu, 22 Mar, 14:11 |
| Harold Dost |
Re: Review Request 66173: Add test for new `disk/xfs` kill functionality. |
Thu, 22 Mar, 14:11 |
| Alexander Rukletsov |
Re: Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'. |
Thu, 22 Mar, 14:27 |
| Jan Schlicht |
Re: Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'. |
Thu, 22 Mar, 14:49 |
| Chun-Hung Hsiao |
Re: Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'. |
Thu, 22 Mar, 15:49 |
| Mesos Reviewbot Windows |
Re: Review Request 66173: Add test for new `disk/xfs` kill functionality. |
Thu, 22 Mar, 16:04 |
| Zhitao Li |
Re: Review Request 66050: Implemented grow and shrink of persistent volumes. |
Thu, 22 Mar, 16:27 |
| Zhitao Li |
Review Request 66218: Ensured that agent does not delete volume upon grow or shrink. |
Thu, 22 Mar, 16:28 |
| Zhitao Li |
Review Request 66219: Added helper functions to create grow and shrink volume in test. |
Thu, 22 Mar, 16:29 |
| Zhitao Li |
Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations. |
Thu, 22 Mar, 16:30 |
| Meng Zhu |
Re: Review Request 66143: Refactored agent task launch for better composition [2/2]. |
Thu, 22 Mar, 17:26 |
| Meng Zhu |
Re: Review Request 66143: Refactored agent task launch for better composition [2/2]. |
Thu, 22 Mar, 17:26 |
| Mesos Reviewbot Windows |
Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations. |
Thu, 22 Mar, 17:48 |
| Greg Mann |
Re: Review Request 66120: Updated an agent test to use mock garbage collector. |
Thu, 22 Mar, 17:49 |
| James Peach |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Thu, 22 Mar, 18:19 |
| Gaston Kleiman |
Re: Review Request 65300: Added master metrics for operation status acknowledgments handling. |
Thu, 22 Mar, 18:25 |
| Gaston Kleiman |
Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler. |
Thu, 22 Mar, 18:26 |
| Gaston Kleiman |
Re: Review Request 66140: Fixed bug in `Framework::removeOperation()`. |
Thu, 22 Mar, 18:26 |
| Gaston Kleiman |
Re: Review Request 65993: Added evolve functions for operation status updates. |
Thu, 22 Mar, 18:26 |
| Gaston Kleiman |
Re: Review Request 65994: Made the master forward operation status updates to the schedulers. |
Thu, 22 Mar, 18:27 |
| Gaston Kleiman |
Re: Review Request 66056: Updated `CREATE_VOLUME()` helper to allow specifying an operation ID. |
Thu, 22 Mar, 18:27 |
| Gaston Kleiman |
Re: Review Request 66057: Added a `createCallAcknowledgeOperationStatus()` test helper. |
Thu, 22 Mar, 18:27 |
| Gaston Kleiman |
Re: Review Request 66058: Added v1 versions of some test helpers/matchers. |
Thu, 22 Mar, 18:27 |
| Gaston Kleiman |
Re: Review Request 66059: Added a `SendAcknowledgeOperationStatus` test action. |
Thu, 22 Mar, 18:27 |
| Gaston Kleiman |
Re: Review Request 66060: Added end-to-end tests for operation feedback. |
Thu, 22 Mar, 18:28 |
| Gaston Kleiman |
Re: Review Request 66141: Fixed whitespace in SLRP tests. |
Thu, 22 Mar, 18:28 |
| James Peach |
Re: Review Request 66173: Add test for new `disk/xfs` kill functionality. |
Thu, 22 Mar, 18:31 |
| Chun-Hung Hsiao |
Re: Review Request 66206: Used native protobuf map in Docker v1 image spec. |
Thu, 22 Mar, 18:39 |
| Meng Zhu |
Re: Review Request 66120: Updated an agent test to use mock garbage collector. |
Thu, 22 Mar, 18:43 |
| Gaston Kleiman |
Re: Review Request 66060: Added end-to-end tests for operation feedback. |
Thu, 22 Mar, 19:06 |
| Meng Zhu |
Re: Review Request 66144: Enforced task launch order on the agent. |
Thu, 22 Mar, 19:07 |
| Chun-Hung Hsiao |
Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes. |
Thu, 22 Mar, 19:28 |
| Zhitao Li |
Review Request 66227: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API. |
Thu, 22 Mar, 20:35 |
| Kapil Arya |
Review Request 66228: Added call/event for updating framework info. |
Thu, 22 Mar, 20:53 |
| Kapil Arya |
Review Request 66229: Implemented UPDATE_FRAMEWORK call. |
Thu, 22 Mar, 20:53 |
| Kapil Arya |
Review Request 66230: Added test for adding/removing framework roles. |
Thu, 22 Mar, 20:53 |
| Sagar Patwardhan |
Re: Review Request 65987: Allow nested containers in pods to have separate namespaces(Ref: MESOS-8534). |
Thu, 22 Mar, 21:16 |
| Mesos Reviewbot |
Re: Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'. |
Thu, 22 Mar, 21:17 |
| Mesos Reviewbot Windows |
Re: Review Request 66227: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API. |
Thu, 22 Mar, 21:35 |
| Mesos Reviewbot Windows |
Re: Review Request 66230: Added test for adding/removing framework roles. |
Thu, 22 Mar, 21:36 |
| Zhitao Li |
Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes. |
Thu, 22 Mar, 22:36 |
| Chun-Hung Hsiao |
Re: Review Request 66050: Implemented grow and shrink of persistent volumes. |
Thu, 22 Mar, 22:43 |
| Mesos Reviewbot Windows |
Re: Review Request 66230: Added test for adding/removing framework roles. |
Thu, 22 Mar, 22:54 |
| Gilbert Song |
Re: Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins. |
Thu, 22 Mar, 23:08 |
| Mesos Reviewbot |
Re: Review Request 66173: Add test for new `disk/xfs` kill functionality. |
Thu, 22 Mar, 23:39 |
| Greg Mann |
Re: Review Request 66126: Refactored agent task launch for better composition [1/2]. |
Fri, 23 Mar, 01:02 |
| Gaston Kleiman |
Re: Review Request 66123: Temporarily disabled some default executor tests. |
Fri, 23 Mar, 01:05 |
| Qian Zhang |
Re: Review Request 66076: Used raw string literal in protobuf tests to avoid escaping. |
Fri, 23 Mar, 01:11 |
| Qian Zhang |
Re: Review Request 66076: Used raw string literal in protobuf tests to avoid escaping. |
Fri, 23 Mar, 01:12 |
| Mesos Reviewbot Windows |
Re: Review Request 66123: Temporarily disabled some default executor tests. |
Fri, 23 Mar, 02:03 |
| Gaston Kleiman |
Review Request 66223: WIP. |
Fri, 23 Mar, 02:07 |
| Gaston Kleiman |
Review Request 66232: Removed unnecessary/invalid checks from the default executor. |
Fri, 23 Mar, 02:10 |
| Gaston Kleiman |
Re: Review Request 65694: Made the default executor's handling of kill escalations more robust. |
Fri, 23 Mar, 02:12 |
| Gaston Kleiman |
Review Request 66233: Made the default executor log kill failures. |
Fri, 23 Mar, 02:13 |
| Gaston Kleiman |
Re: Review Request 65962: Avoided copying `Owned` pointers in the default executor. |
Fri, 23 Mar, 02:13 |
| Gaston Kleiman |
Review Request 66234: Fixed variable shadowing in the default executor. |
Fri, 23 Mar, 02:14 |
| Qian Zhang |
Re: Review Request 66206: Used native protobuf map in Docker v1 image spec. |
Fri, 23 Mar, 02:17 |
| Gaston Kleiman |
Review Request 66235: Added a reference to MESOS-8557 to the default executor. |
Fri, 23 Mar, 02:17 |
| Mesos Reviewbot Windows |
Re: Review Request 66141: Fixed whitespace in SLRP tests. |
Fri, 23 Mar, 03:04 |
| Mesos Reviewbot Windows |
Re: Review Request 66232: Removed unnecessary/invalid checks from the default executor. |
Fri, 23 Mar, 03:24 |
| Mesos Reviewbot Windows |
Re: Review Request 66235: Added a reference to MESOS-8557 to the default executor. |
Fri, 23 Mar, 04:35 |
| Greg Mann |
Re: Review Request 66143: Refactored agent task launch for better composition [2/2]. |
Fri, 23 Mar, 06:00 |
| Greg Mann |
Re: Review Request 66126: Refactored agent task launch for better composition [1/2]. |
Fri, 23 Mar, 06:12 |
| Greg Mann |
Re: Review Request 66143: Refactored agent task launch for better composition [2/2]. |
Fri, 23 Mar, 06:15 |
| Greg Mann |
Re: Review Request 66143: Refactored agent task launch for better composition [2/2]. |
Fri, 23 Mar, 06:15 |
| Mesos Reviewbot |
Re: Review Request 66123: Temporarily disabled some default executor tests. |
Fri, 23 Mar, 06:57 |
| Greg Mann |
Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler. |
Fri, 23 Mar, 07:21 |
| Greg Mann |
Re: Review Request 66144: Enforced task launch order on the agent. |
Fri, 23 Mar, 08:12 |
| Jan Schlicht |
Re: Review Request 66037: Enabled agent resource provider capability by default. |
Fri, 23 Mar, 08:32 |
| Mesos Reviewbot |
Re: Review Request 66141: Fixed whitespace in SLRP tests. |
Fri, 23 Mar, 09:15 |
| Mesos Reviewbot |
Re: Review Request 66235: Added a reference to MESOS-8557 to the default executor. |
Fri, 23 Mar, 11:36 |
| Benno Evers |
Re: Review Request 63733: Don't print full usage for invocation errors. |
Fri, 23 Mar, 14:39 |
| Benno Evers |
Review Request 66248: Re-enabled SlaveTest.ChangeDomain. |
Fri, 23 Mar, 14:40 |
| Benjamin Bannier |
Re: Review Request 66037: Enabled agent resource provider capability by default. |
Fri, 23 Mar, 15:07 |
| Mesos Reviewbot Windows |
Re: Review Request 66248: Re-enabled SlaveTest.ChangeDomain. |
Fri, 23 Mar, 15:36 |
| Mesos Reviewbot |
Re: Review Request 63733: Don't print full usage for invocation errors. |
Fri, 23 Mar, 15:36 |
| Harold Dost |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Fri, 23 Mar, 16:12 |
| Harold Dost |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Fri, 23 Mar, 16:13 |
| Mesos Reviewbot Windows |
Re: Review Request 63733: Don't print full usage for invocation errors. |
Fri, 23 Mar, 16:21 |
| Gaston Kleiman |
Re: Review Request 66037: Enabled agent resource provider capability by default. |
Fri, 23 Mar, 17:29 |
| Mesos Reviewbot |
Re: Review Request 66037: Enabled agent resource provider capability by default. |
Fri, 23 Mar, 17:41 |
| Gaston Kleiman |
Re: Review Request 66232: Removed unnecessary/invalid checks from the default executor. |
Fri, 23 Mar, 17:49 |
| Gaston Kleiman |
Re: Review Request 65695: Made the default executor allow schedulers to retry task kills. |
Fri, 23 Mar, 17:51 |