-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66371/#review200232
-----------------------------------------------------------
Ship it!
This works for me on FreeBSD now, though I'm not sure if it would be better to gate this rather
than removing it completely?
- David Forsythe
On March 29, 2018, 11:58 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66371/
> -----------------------------------------------------------
>
> (Updated March 29, 2018, 11:58 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, David Forsythe, and Jan Schlicht.
>
>
> Bugs: MESOS-8749
> https://issues.apache.org/jira/browse/MESOS-8749
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `major` and `minor` macros defined on some systems conflict with
> field names in the CSI v0.1.0 spec proto. Temporarily disable it in
> CMake until CSI is bumped to 0.2.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt fb9e9d4cfc4a62830fe3065a139ae14401c0e52e
>
>
> Diff: https://reviews.apache.org/r/66371/diff/1/
>
>
> Testing
> -------
>
> `make check` with CMake
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
|