mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 65856: Added `--fetcher_stall_timeout` to abort stalled artifact fetching.
Date Thu, 29 Mar 2018 05:48:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65856/#review200171
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On March 28, 2018, 4:51 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65856/
> -----------------------------------------------------------
> 
> (Updated March 28, 2018, 4:51 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8620
>     https://issues.apache.org/jira/browse/MESOS-8620
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This flag specifies a timeout for `mesos-fetcher` to wait before
> aborting if the download speed keeps below 1 bytes/sec. This would avoid
> containers to get stuck at FETCHING.
> 
> 
> Diffs
> -----
> 
>   docs/configuration/agent.md 13e4c551b8b0ba47190b4016220e48c3a4c391fb 
>   include/mesos/fetcher/fetcher.proto 6a5d807221681853444ffd3ab42a23827604e550 
>   src/launcher/fetcher.cpp 2f42fa221a42fdc131a8a97ded4e9433ce51ea77 
>   src/slave/constants.hpp f1fc2bfcb9e093ab39a550d8fc7daa8fadee6f64 
>   src/slave/containerizer/fetcher.cpp f9ab55404801e27900dc82316c1ca595fd65b942 
>   src/slave/flags.hpp 949a4783caf8aac9a246a98525a5287b0f8256d8 
>   src/slave/flags.cpp 962b07c1d701f4ab819b14730fbc116b981433bb 
> 
> 
> Diff: https://reviews.apache.org/r/65856/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> Manually tested with Nginx servers with the following cases:
> 1. Sleeps for 59 seconds before serving artifacts (successful)
> 2. Sleeps for 1 mintue before serving artifacts (failed)
> 3. Sleeps for 55 seconds and then serve a 640B artifact with 12 bytes/second (successful)
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message