-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66325/
-----------------------------------------------------------
(Updated March 28, 2018, 10:20 p.m.)
Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
Changes
-------
Added validations for `info.id` and made the quoting marks in error messages consistent.
Bugs: MESOS-8742
https://issues.apache.org/jira/browse/MESOS-8742
Repository: mesos
Description
-------
`ADD_RESOURCE_PROVIDER_CONFIG`, `UPDATE_RESOURCE_PROVIDER_CONFIG` and
`REMOVE_RESOURCE_PROVIDER_CONFIG` now return 200 for identical
repetivite calls.
Diffs (updated)
-----
src/resource_provider/daemon.cpp d0a8186da80a1bffbb71f524e639bc7d75ef6243
src/resource_provider/storage/provider.cpp 8db1ce0589be2885cd970f029027fb73c5cbc09f
src/slave/http.cpp 65081c95c888a8236aafdfc627a7aa4e9a72b65d
Diff: https://reviews.apache.org/r/66325/diff/2/
Changes: https://reviews.apache.org/r/66325/diff/1-2/
Testing
-------
make
NOTE: Test `*/AgentResourceProviderConfigApiTest.RemoveNotFound` won't pass since the semantics
of `REMOVE_RESOURCE_PROVIDER_CONFIG` is changed.
Tests are added in the next patch.
Thanks,
Chun-Hung Hsiao
|