mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 66206: Used native protobuf map in Docker v1 image spec.
Date Wed, 28 Mar 2018 21:47:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66206/#review200141
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On March 21, 2018, 11:56 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66206/
> -----------------------------------------------------------
> 
> (Updated March 21, 2018, 11:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Gilbert Song.
> 
> 
> Bugs: MESOS-8702
>     https://issues.apache.org/jira/browse/MESOS-8702
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used native protobuf map in Docker v1 image spec.
> 
> 
> Diffs
> -----
> 
>   include/mesos/docker/v1.proto 338675490b7e624196bbb745173daa028a13280c 
>   src/docker/spec.cpp 15224f90f965079ff83dfedff0182a97a5ff0360 
>   src/slave/containerizer/mesos/isolators/gpu/volume.cpp 536a3c711faf3c165bebaaa3c92717737d67b6f3

>   src/tests/containerizer/docker_spec_tests.cpp 5fde49a495c2a2fa880e7cb1bae2f636edecd480

> 
> 
> Diff: https://reviews.apache.org/r/66206/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message