mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 66218: Ensured that agent does not delete volume upon grow or shrink.
Date Tue, 27 Mar 2018 22:37:56 GMT


> On March 27, 2018, 12:14 p.m., Chun-Hung Hsiao wrote:
> > src/slave/slave.cpp
> > Lines 4169-4184 (patched)
> > <https://reviews.apache.org/r/66218/diff/3/?file=1988977#file1988977line4169>
> >
> >     This is not a `set` operation but a `hashset` operation, so the comments are
incorrect. Could you experiment on adding this operaton in `stout/hashset.hpp` and see if
it works?

Actually this is a bug as `set_diffrence` requirs iteration to have order while this does
not.

Let me fix it differently in hashset.hpp and list as a precendent. I will also check persistent
volume content in test patch.


- Zhitao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66218/#review200062
-----------------------------------------------------------


On March 26, 2018, 11:36 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66218/
> -----------------------------------------------------------
> 
> (Updated March 26, 2018, 11:36 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-4965
>     https://issues.apache.org/jira/browse/MESOS-4965
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, `slave::syncCheckpointedResources` implementation will
> delete a persistent volume using `Resources::contains` check, which
> could cause a resized volume being deleted. The function was rewritten
> to compare `set_difference` between old and new paths for all persistent
> volumes and perform creation/deletion accordingly.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp e76daabad0d2d68aa42d1da809d4a23459eaaacb 
> 
> 
> Diff: https://reviews.apache.org/r/66218/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message