mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 66219: Added helper functions to create grow and shrink volume in test.
Date Tue, 27 Mar 2018 02:03:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66219/#review200015
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/mesos.hpp
Lines 1320 (patched)
<https://reviews.apache.org/r/66219/#comment280613>

    Indent by 4 spaces instead of 2 and break the parameters into two lines. Ditto below.


- Chun-Hung Hsiao


On March 26, 2018, 4:54 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66219/
> -----------------------------------------------------------
> 
> (Updated March 26, 2018, 4:54 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-4965
>     https://issues.apache.org/jira/browse/MESOS-4965
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added helper functions to create grow and shrink volume in test.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 2c3d0c9350bbbbcd2223ff20c0797d1849d38c19 
> 
> 
> Diff: https://reviews.apache.org/r/66219/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message