mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 66218: Ensured that agent does not delete volume upon grow or shrink.
Date Tue, 27 Mar 2018 01:29:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66218/#review200011
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/slave.cpp
Line 4173 (original), 4191 (patched)
<https://reviews.apache.org/r/66218/#comment280607>

    This line can be removed.



src/slave/slave.cpp
Lines 4205-4209 (patched)
<https://reviews.apache.org/r/66218/#comment280608>

    ```
    const hashmap<string, Resource> oldPathMap =
    ```
    and use `oldPathMap.at(path)` below.
    
    Ditto on `newPathMap`.


- Chun-Hung Hsiao


On March 26, 2018, 4:53 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66218/
> -----------------------------------------------------------
> 
> (Updated March 26, 2018, 4:53 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-4965
>     https://issues.apache.org/jira/browse/MESOS-4965
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, `slave::syncCheckpointedResources` implementation will
> delete a persistent volume using `Resources::contains` check, which
> could cause a resized volume being deleted. The function was rewritten
> to compare `set_difference` between old and new paths for all persistent
> volumes and perform creation/deletion accordingly.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp e76daabad0d2d68aa42d1da809d4a23459eaaacb 
> 
> 
> Diff: https://reviews.apache.org/r/66218/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message