mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 66255: Temporarily disabled CSI proto compilation when gRPC is disabled.
Date Fri, 23 Mar 2018 20:44:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66255/
-----------------------------------------------------------

(Updated March 23, 2018, 8:44 p.m.)


Review request for mesos, Benno Evers, Jie Yu, James Peach, Kapil Arya, and Zhitao Li.


Bugs: MESOS-8724
    https://issues.apache.org/jira/browse/MESOS-8724


Repository: mesos


Description
-------

The `major` and `minor` macros defined on some systems conflict with
field names in the CSI spec proto, so its compilation is temporarily
disabled for now until CSI is bumped to 0.2, where those field are
removed.


Diffs (updated)
-----

  src/CMakeLists.txt 3b04e6353979c05a38f1b032704dce566d8fd561 
  src/Makefile.am 56ce55480553c08450830987f217d0abedd5b2b8 
  src/slave/flags.cpp dd8dfb7a8a9f7c6030939c9eea841eb47deadfc4 
  src/slave/slave.cpp e76daabad0d2d68aa42d1da809d4a23459eaaacb 


Diff: https://reviews.apache.org/r/66255/diff/2/

Changes: https://reviews.apache.org/r/66255/diff/1-2/


Testing
-------

`make check` on CentOS (w/ and w/o gRPC) and Mac (w/o gRPC)


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message