mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 65855: Added the `stall_timeout` parameter to `net::download()`.
Date Fri, 23 Mar 2018 18:13:12 GMT


> On March 21, 2018, 10:35 p.m., Gilbert Song wrote:
> > 3rdparty/stout/include/stout/net.hpp
> > Lines 144 (patched)
> > <https://reviews.apache.org/r/65855/diff/1/?file=1968109#file1968109line144>
> >
> >     I think we follow the style that naming parameter as `stallTimeout`

The Mesos C++ style guide says that in general we use snake cases in stout, althought there're
some violations ;)


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65855/#review199717
-----------------------------------------------------------


On March 1, 2018, 5:13 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65855/
> -----------------------------------------------------------
> 
> (Updated March 1, 2018, 5:13 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8620
>     https://issues.apache.org/jira/browse/MESOS-8620
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When the `stall_timeout` is given, the download would be aborted if the
> download speed keeps below 1 byte per second during the timeout.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/net.hpp abb01446d631a67c5182514e3d1368377a0575fc 
> 
> 
> Diff: https://reviews.apache.org/r/65855/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make test
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message