mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Review Request 66248: Re-enabled SlaveTest.ChangeDomain.
Date Fri, 23 Mar 2018 14:40:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66248/
-----------------------------------------------------------

Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-8711
    https://issues.apache.org/jira/browse/MESOS-8711


Repository: mesos


Description
-------

This test was originally written with the assumption that the
would give get a new agent id after receiving a Shutdown
message from the master.

When that behaviour was changed, the test was disabled since it
could not recover the previous agent id when a fault domain
was added.

With the introduction of reconfiguration policies, this became
possible, so the test can be re-enabled. Note that after adding
the necessary modifications, the test becomes very similar but
not completely identical to SlaveTest.ReconfigurationPolicy.


Diffs
-----

  src/tests/slave_tests.cpp 028cd32c7043eba4e6f2045956471bd0bf42371c 


Diff: https://reviews.apache.org/r/66248/diff/1/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message