mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 65856: Added `--fetcher_stall_timeout` to abort stalled artifact fetching.
Date Thu, 22 Mar 2018 03:37:36 GMT


> On March 21, 2018, 11:06 p.m., Gilbert Song wrote:
> > src/slave/flags.cpp
> > Lines 251-257 (patched)
> > <https://reviews.apache.org/r/65856/diff/1/?file=1968115#file1968115line251>
> >
> >     Should we update `configuration/agent.md`?

In those docs we should make it clear what kinds of fetches this applies to, e.g it won't
apply to HDFS.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65856/#review199719
-----------------------------------------------------------


On March 1, 2018, 5:17 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65856/
> -----------------------------------------------------------
> 
> (Updated March 1, 2018, 5:17 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8620
>     https://issues.apache.org/jira/browse/MESOS-8620
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This flag specifies a timeout for `mesos-fetcher` to wait before
> aborting if the download speed keeps below 1 bytes/sec. This would avoid
> containers to get stuck at FETCHING. The default value is 1 minute.
> 
> 
> Diffs
> -----
> 
>   include/mesos/fetcher/fetcher.proto 6a5d807221681853444ffd3ab42a23827604e550 
>   src/launcher/fetcher.cpp 2f42fa221a42fdc131a8a97ded4e9433ce51ea77 
>   src/slave/constants.hpp 030fb05186f7f360010bb7e5b4948faac69771cc 
>   src/slave/containerizer/fetcher.cpp a49411b7bac2d5a50a75d0b802842c2f61fe58c6 
>   src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e 
>   src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc 
> 
> 
> Diff: https://reviews.apache.org/r/65856/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> Manually tested with Nginx servers with the following cases:
> 1. Sleeps for 59 seconds before serving artifacts (successful)
> 2. Sleeps for 1 mintue before serving artifacts (failed)
> 3. Sleeps for 55 seconds and then serve a 640B artifact with 12 bytes/second (successful)
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message