mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 66178: Added a test to verify that task launch order is enforced.
Date Wed, 21 Mar 2018 21:58:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66178/
-----------------------------------------------------------

(Updated March 21, 2018, 2:58 p.m.)


Review request for mesos, Chun-Hung Hsiao and Greg Mann.


Changes
-------

Thanks for the review! Patch updated.


Bugs: MESOS-8617 and MESOS-8624
    https://issues.apache.org/jira/browse/MESOS-8617
    https://issues.apache.org/jira/browse/MESOS-8624


Repository: mesos


Description
-------

Agent should launch the task in their receiving order.
On the task launch path, there are currently two
asynchronous steps which may complete out of order:
unschedule GC and task authorization.

This test simulates the reordering of the completions
of task authorization step and verify that, despite the
reordering, tasks can still launch in their original order.


Diffs (updated)
-----

  src/tests/mesos.hpp 2c3d0c9350bbbbcd2223ff20c0797d1849d38c19 
  src/tests/mesos.cpp d82963195573dd9ed7d12a7708f64a236b28cdf1 
  src/tests/slave_tests.cpp f76500ebdb67f131a57a3b5aaae8c952d019e354 


Diff: https://reviews.apache.org/r/66178/diff/2/

Changes: https://reviews.apache.org/r/66178/diff/1-2/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message