-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66156/
-----------------------------------------------------------
(Updated March 21, 2018, 7:32 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Changes
-------
Added a TODO to address Benjamin's comment.
Bugs: MESOS-8492
https://issues.apache.org/jira/browse/MESOS-8492
Repository: mesos
Description
-------
By generating `csi.pb.h` even if gRPC is disabled, other Mesos protocol
buffers can embed the CSI protocol buffers. This is required if we want
to checkpoint disk profiles in `ResourceProviderState`.
Moreover, we relaxed the precondition of compiling most files, as the
gRPC is only required by SLRP, CSI clients and the tests.
Diffs (updated)
-----
3rdparty/Makefile.am f4cb731198e271b967b920235ed2785e9296f9e1
include/csi/spec.hpp df01f44e6f89a03eff9aef77c29ca71495d767f2
src/CMakeLists.txt fb9e9d4cfc4a62830fe3065a139ae14401c0e52e
src/Makefile.am 84753794eca822ab251200cccb907b328c849fb7
src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
src/slave/flags.cpp 962b07c1d701f4ab819b14730fbc116b981433bb
src/slave/slave.cpp 336c90603e94e6c45e1d1222d53e4e1b0db3f9ca
Diff: https://reviews.apache.org/r/66156/diff/3/
Changes: https://reviews.apache.org/r/66156/diff/2-3/
Testing
-------
`sudo make check`
`make distcheck` with and without `--enable-grpc`
Thanks,
Chun-Hung Hsiao
|