mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 66165: Re-fixed many master allocator tests.
Date Wed, 21 Mar 2018 01:56:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66165/#review199629
-----------------------------------------------------------



Bad patch!

Reviews applied: [66165, 66164]

Failed command: python support/apply-reviews.py -n -r 66164

Error:
2018-03-21 01:56:16 URL:https://reviews.apache.org/r/66164/diff/raw/ [1127/1127] -> "66164.patch"
[1]
error: patch failed: src/master/master.cpp:6235
error: src/master/master.cpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/21962/console

- Mesos Reviewbot


On March 20, 2018, 1:36 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66165/
> -----------------------------------------------------------
> 
> (Updated March 20, 2018, 1:36 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Bugs: MESOS-8613
>     https://issues.apache.org/jira/browse/MESOS-8613
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When the slave has a very short lifetime, its scheduled registration
> retry might occur when the test is tearing down. These unintuitively
> motivated registrations in turn cause additional invocations of
> `AddSlave` on the allocator.
> Additionally, this also reverts the newly introduced Clock pauses as
> they have shown to be problematic.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_allocator_tests.cpp 1ceb8e8a57ab300a957931d5ad3d54904e555597 
> 
> 
> Diff: https://reviews.apache.org/r/66165/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> Ran the MasterAllocatorTests 10k times without any hiccups.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message