mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 65695: Made the default executor allow schedulers to retry task kills.
Date Tue, 20 Mar 2018 20:50:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65695/
-----------------------------------------------------------

(Updated March 20, 2018, 1:50 p.m.)


Review request for mesos, Alexander Rukletsov, Joseph Wu, Qian Zhang, and Vinod Kone.


Changes
-------

Addressed AlexR's feedback.


Bugs: MESOS-8530
    https://issues.apache.org/jira/browse/MESOS-8530


Repository: mesos


Description
-------

The default executor transitions a task to `TASK_KILLING` and marks its
child container as being killed before posting a `KILL` call to the
agent.

The executor ignores kill requests for containers that are marked as
being killed, and it doesn't remove this mark if the `KILL` call fails.
This means that it's possible for tasks to get stuck in a `TASK_KILLING`
state.

This patch makes the default executor remove the killing mark if a
`KILL` call fails. That way a scheduler can retry a kill.


Diffs (updated)
-----

  src/launcher/default_executor.cpp 906836f3b8e0af79d7c61f90fd8a95f193b26e84 


Diff: https://reviews.apache.org/r/65695/diff/4/

Changes: https://reviews.apache.org/r/65695/diff/3-4/


Testing
-------

`sudo bin/mesos-tests.sh` on GNU/Linux


Thanks,

Gaston Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message