mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Review Request 66165: Re-fixed many master allocator tests.
Date Tue, 20 Mar 2018 20:36:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66165/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov and Benjamin Bannier.


Bugs: MESOS-8613
    https://issues.apache.org/jira/browse/MESOS-8613


Repository: mesos


Description
-------

When the slave has a very short lifetime, its scheduled registration
retry might occur when the test is tearing down. These unintuitively
motivated registrations in turn cause additional invocations of
`AddSlave` on the allocator.
Additionally, this also reverts the newly introduced Clock pauses as
they have shown to be problematic.


Diffs
-----

  src/tests/master_allocator_tests.cpp 1ceb8e8a57ab300a957931d5ad3d54904e555597 


Diff: https://reviews.apache.org/r/66165/diff/1/


Testing
-------

make check

Ran the MasterAllocatorTests 10k times without any hiccups.


Thanks,

Till Toenshoff


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message