mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 66096: Adapted the new `grpcpp` C++ headers for gRPC v1.10 in libprocess.
Date Tue, 20 Mar 2018 15:09:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66096/#review199550
-----------------------------------------------------------


Ship it!




Looking good. Surprised they didn't provide another name for the library as well.

Could you expand the commit message a little to call out that this patch moves us off headers
deprecated by upstream and we do not expect any functional changes?

- Benjamin Bannier


On March 15, 2018, 8:20 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66096/
> -----------------------------------------------------------
> 
> (Updated March 15, 2018, 8:20 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-8678
>     https://issues.apache.org/jira/browse/MESOS-8678
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adapted the new `grpcpp` C++ headers for gRPC v1.10 in libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/configure.ac 69ec9b9683199f580405e38ec16a581a01f919c4 
>   3rdparty/libprocess/include/process/grpc.hpp edaf0410c62454df53d06957a4a8f1f6027b00bb

> 
> 
> Diff: https://reviews.apache.org/r/66096/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo make check` for Mesos and libprocess.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message