mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 65640: Fixed leaks and a race condition in `UriDiskProfileAdaptorTests`.
Date Tue, 20 Mar 2018 03:23:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65640/
-----------------------------------------------------------

(Updated March 20, 2018, 3:23 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Jie Yu, and Joseph Wu.


Changes
-------

Rebased.


Summary (updated)
-----------------

Fixed leaks and a race condition in `UriDiskProfileAdaptorTests`.


Bugs: MESOS-8567
    https://issues.apache.org/jira/browse/MESOS-8567


Repository: mesos


Description
-------

There was a race between `Clock::advance()` in the `FetchFromHTTP` test
and `delay()` in `UriDiskProfileAdaptorProcess::_poll`. This patch
avoids the race by enforcing an order between the dispatch of the
`__poll` function (previously `_poll`) and the clock manipulation
in the test. It also fixed two memory leaks in the test.


Diffs (updated)
-----

  src/Makefile.am 84753794eca822ab251200cccb907b328c849fb7 
  src/resource_provider/storage/uri_disk_profile_adaptor.hpp PRE-CREATION 
  src/resource_provider/storage/uri_disk_profile_adaptor.cpp 665798fdb085ea34f93bd287fe6f9ab29a265cbf

  src/tests/disk_profile_adaptor_tests.cpp 577ccfe9614009ba4178886c100de22ff12047b6 


Diff: https://reviews.apache.org/r/65640/diff/3/

Changes: https://reviews.apache.org/r/65640/diff/2-3/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message