mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <>
Subject Re: Review Request 61096: Building gRPC with CMake.
Date Mon, 19 Mar 2018 23:50:43 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 19, 2018, 11:50 p.m.)

Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.

Summary (updated)

Building gRPC with CMake.

Bugs: MESOS-7808

Repository: mesos

Description (updated)

This patch adds an `ENABLE_GRPC` option and builds the bundled gRPC
3rdparty library in CMake.

Diffs (updated)

  3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 
  3rdparty/cmake/Versions.cmake 93f0322c1ac926bcfdcd4c1cfd9ba9f22bcf7099 
  cmake/CompilationConfigure.cmake 64cc56ee4208afe05df0f28af5890157e4c7d82c 
  src/cmake/MesosProtobuf.cmake dde034fe4d4251dd7c7397d422136bfa3c9c3ebc 



Testing (updated)

`sudo make check` with CMake

NOTE: Testing on Windowns is not done yet.


Chun-Hung Hsiao

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message