mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Review Request 66159: Made tests `CSIClientTest.*` cross-platform.
Date Mon, 19 Mar 2018 23:41:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66159/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Jie Yu.


Bugs: MESOS-8697
    https://issues.apache.org/jira/browse/MESOS-8697


Repository: mesos


Description
-------

The `CSIClientTest.*` tests now use in-process channels instead of
Unix domain sockets, so it can be run on Windows.


Diffs
-----

  src/csi/client.hpp 0ff97eea9f27bff0ce79acb5a212aaa7a4098a55 
  src/tests/csi_client_tests.cpp 2c5dbb7d0f794cb520b0ca4e7761f8bb51ce5ab2 
  src/tests/mock_csi_plugin.hpp c1a96973574628a261b3d727c764cd0de10a5268 
  src/tests/mock_csi_plugin.cpp 46ca398e48578537393e4050c3a9920b367b8946 


Diff: https://reviews.apache.org/r/66159/diff/1/


Testing
-------

sudo make check


NOTE: This is not tested on Windows yet. The CMake rules are added later in the chain.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message