mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Review Request 66156: Compiled `csi.proto` when gRPC is disabled.
Date Mon, 19 Mar 2018 23:29:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66156/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Jie Yu.


Bugs: MESOS-8492
    https://issues.apache.org/jira/browse/MESOS-8492


Repository: mesos


Description
-------

By generating `csi.pb.h` even if gRPC is disabled, other Mesos protocol
buffers can embed the CSI protocol buffers. This is required if we want
to checkpoint disk profiles in `ResourceProviderState`.

Moreover, we relaxed the precondition of compiling most files, as the
gRPC is only required by SLRP, CSI clients and the tests.


Diffs
-----

  3rdparty/Makefile.am f4cb731198e271b967b920235ed2785e9296f9e1 
  include/csi/spec.hpp df01f44e6f89a03eff9aef77c29ca71495d767f2 
  src/Makefile.am 84753794eca822ab251200cccb907b328c849fb7 
  src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e 
  src/slave/flags.cpp 962b07c1d701f4ab819b14730fbc116b981433bb 
  src/slave/slave.cpp 915d4f1bbd642ca5d2587cfdd846262cb7e08788 


Diff: https://reviews.apache.org/r/66156/diff/1/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message