mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <>
Subject Re: Review Request 66046: CMake: Patched Boost to remove spurious warnings.
Date Mon, 19 Mar 2018 19:14:39 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 19, 2018, 12:14 p.m.)

Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph
Wu, and Michael Park.



Bugs: MESOS-8556

Repository: mesos


On Windows, Boost explicitly checks if it's being compiled with a
compiler version they've tested. As we tend to update Visual Studio
whenever a stable update is available, this leads to a Boost warning,
"Unknown compiler version..." being emitted repeatedly (for every file
which includes a Boost header).

If it were emitted once, we would leave it be, but because it's
repeated hundreds of times, and is mostly harmless, we patch the build
to remove the warning itself. Unfortunately, there is no compile-time
option to disable the warning instead of a patch.

Note that it is not straight-forward to generate a patch file for
Boost. The steps were: clone the Boost repo recursively, go the
`libs/config` submodule, edit the `visualc.hpp` file, go to the
`include` subdirectory, and use `git diff --relative` to generate the
patch with the corrects paths expected for the extracted tarball.

Diffs (updated)

  3rdparty/CMakeLists.txt e0c1538eaaef4bf6a198e89867a13763f264deb3 
  3rdparty/boost-1.65.0.patch PRE-CREATION 




Built on Windows; no more warning.


Andrew Schwartzmeyer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message