mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66011: Windows: Set 3rdparty libraries to link to CRT dynamically.
Date Mon, 19 Mar 2018 19:13:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66011/
-----------------------------------------------------------

(Updated March 19, 2018, 12:13 p.m.)


Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph
Wu, and Michael Park.


Changes
-------

Rebased.


Bugs: MESOS-8659
    https://issues.apache.org/jira/browse/MESOS-8659


Repository: mesos


Description
-------

This also fixes a bug where the `libevent` build on Windows would add
`''` to the compiler flags, which is an unrecognized flag, and sets
the names of our `CMAKE_FORWARD_ARGS` variables consistently (some
were missing the `FORWARD` part).


Diffs (updated)
-----

  3rdparty/CMakeLists.txt e0c1538eaaef4bf6a198e89867a13763f264deb3 


Diff: https://reviews.apache.org/r/66011/diff/3/

Changes: https://reviews.apache.org/r/66011/diff/2-3/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message