mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66010: Windows: Switched to default CRT linkage.
Date Mon, 19 Mar 2018 19:12:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66010/
-----------------------------------------------------------

(Updated March 19, 2018, 12:12 p.m.)


Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph
Wu, and Michael Park.


Changes
-------

Removed superfluous variable.


Bugs: MESOS-8659
    https://issues.apache.org/jira/browse/MESOS-8659


Repository: mesos


Description
-------

We previously attempted to manually override the CRT to be static
everywhere. Not only did this emit warnings, it was also error-prone
and unnecessary. We can, and should, just use the defaults, which is
`/MDd` in debug mode (multi-threaded, dynamic, debug linkage). Linking
to the CRT dynamically results in smaller libraries and executables,
reduces linking time, and avoids bugs when sharing allocated memory
across modules.


Diffs (updated)
-----

  cmake/CompilationConfigure.cmake efee36c1ffda096a97af23d481fc0d0903124e54 


Diff: https://reviews.apache.org/r/66010/diff/3/

Changes: https://reviews.apache.org/r/66010/diff/2-3/


Testing
-------

NOTE: I checked with Alex Ionescu and since we are deploying on the same OS versions as we're
targetting, we don't need to worry about redistributing the CRT.

If/when we start deploying on older OS versions, we can simply add instructions on installing
the correct CRT redistributable (or make it part of the eventual installer).


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message