mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <>
Subject Re: Review Request 66008: CMake: Enabled compiler warnings.
Date Mon, 19 Mar 2018 19:08:49 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 19, 2018, 12:08 p.m.)

Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph
Wu, and Michael Park.


Addressed Benjamin's comment by making this a 1-1 mapping of the existing `-Werror` semantics.
Instead of setting it as public compile option for `libmesos`, we set as a default compile
option for the `src` directory recursively.

Bugs: MESOS-8033 and MESOS-8658

Repository: mesos


We had previously been using the default sets of warnings, but now we
use the same warnings as on Autotools. This also means that we can
safely turn on the treat-warnings-as-errors (at least for the Mesos
code). However, doing so requires that we disable two common
possible-loss-of-data warnings on Windows that are not part of the
GNU/Clang default warnings.

Because `-Werror` semantics can be burdensome, it can be turned off at
configuration time with `-DENABLE_WERROR=FALSE`. It is on by default.

This also replaces the use of `string(APPEND CMAKE_CXX_FLAGS)` with
the canonical command `add_compile_options`. Although generally the
use of `target_compile_options` is preferred, it would currently
result in a lot more churn, and the build already supports setting
these flags globally.

Diffs (updated)

  cmake/CompilationConfigure.cmake efee36c1ffda096a97af23d481fc0d0903124e54 
  docs/configuration/ 1e34657ea55fa324f65f865f7d0a67084c6719d9 
  src/CMakeLists.txt fb9e9d4cfc4a62830fe3065a139ae14401c0e52e 





Andrew Schwartzmeyer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message