mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66008: CMake: Enabled compiler warnings.
Date Mon, 19 Mar 2018 17:05:12 GMT


> On March 19, 2018, 6:35 a.m., Benjamin Bannier wrote:
> > src/CMakeLists.txt
> > Lines 484-486 (patched)
> > <https://reviews.apache.org/r/66008/diff/2/?file=1975960#file1975960line484>
> >
> >     Let's make this a `PRIVATE` option. We wouldn't necessarily want to push this
on each and every user.

Hm, then we should at least add it to `mesos-tests` too. I might right a function `ENABLE_WERROR(<target>)`
to avoid duplicating this code over and over if we want to keep it private. Sound good?


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66008/#review199413
-----------------------------------------------------------


On March 14, 2018, 4:10 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66008/
> -----------------------------------------------------------
> 
> (Updated March 14, 2018, 4:10 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich,
Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-8033 and MESOS-8658
>     https://issues.apache.org/jira/browse/MESOS-8033
>     https://issues.apache.org/jira/browse/MESOS-8658
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We had previously been using the default sets of warnings, but now we
> use the same warnings as on Autotools. This also means that we can
> safely turn on the treat-warnings-as-errors (at least for the Mesos
> code). However, doing so requires that we disable two common
> possible-loss-of-data warnings on Windows that are not part of the
> GNU/Clang default warnings.
> 
> Because `-Werror` semantics can be burdensome, it can be turned off at
> configuration time with `-DENABLE_WERROR=FALSE`. It is on by default.
> 
> This also replaces the use of `string(APPEND CMAKE_CXX_FLAGS)` with
> the canonical command `add_compile_options`. Although generally the
> use of `target_compile_options` is preferred, it would currently
> result in a lot more churn, and the build already supports setting
> these flags globally.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake efee36c1ffda096a97af23d481fc0d0903124e54 
>   docs/configuration/cmake.md 1e34657ea55fa324f65f865f7d0a67084c6719d9 
>   src/CMakeLists.txt 0c135034982a6a4844509cd0e9b2cc41804333ef 
> 
> 
> Diff: https://reviews.apache.org/r/66008/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message