mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 63994: Added a new test for validation of offer operation IDs.
Date Fri, 16 Mar 2018 00:23:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63994/#review199305
-----------------------------------------------------------




src/tests/scheduler_tests.cpp
Lines 1239-1240 (patched)
<https://reviews.apache.org/r/63994/#comment279602>

    Do we need this? My understanding is that frameworks will get offers as soon as they register,
without having to manually advance the clock.



src/tests/scheduler_tests.cpp
Lines 1251-1256 (patched)
<https://reviews.apache.org/r/63994/#comment279601>

    The following is shorter/more readable:
    
    ```
    Resources resources = Resources::parse("cpus:0.1")->pushReservation(createDynamicReservationInfo(
            "RESERVED_ROLE"));
    ```


- Gaston Kleiman


On March 15, 2018, 5:06 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63994/
> -----------------------------------------------------------
> 
> (Updated March 15, 2018, 5:06 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
> 
> 
> Bugs: MESOS-8190
>     https://issues.apache.org/jira/browse/MESOS-8190
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds three new scheduler tests,
> 'OperationFeedbackValidationWithResourceProviderCapability',
> 'OperationFeedbackValidationNoResourceProviderCapability', and
> 'OperationFeedbackValidationSchedulerDriverFramework', to verify
> that task and operation status updates, and error messages, are
> correctly sent when the 'id' field is set incorrectly on an
> operation.
> 
> 
> Diffs
> -----
> 
>   src/tests/scheduler_tests.cpp 397a0908432ad50fa94fd939a604b096a06f8a1d 
> 
> 
> Diff: https://reviews.apache.org/r/63994/diff/6/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message