mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.
Date Fri, 16 Mar 2018 00:10:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63992/#review199303
-----------------------------------------------------------




src/master/master.cpp
Lines 4092-4098 (patched)
<https://reviews.apache.org/r/63992/#comment279599>

    I wonder if doing the following would leverage the move semantics and avoid unnecessary
copying:
    
    ```
    *update.mutable_update_operation_status() = protobuf::createOperationStatus(...);
    ```


- Gaston Kleiman


On March 15, 2018, 5:02 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63992/
> -----------------------------------------------------------
> 
> (Updated March 15, 2018, 5:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
> 
> 
> Bugs: MESOS-8190
>     https://issues.apache.org/jira/browse/MESOS-8190
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds code to send operation status updates in the master's
> ACCEPT call handler. In cases where operations are dropped and in
> cases where offer operation IDs are set when they should not be, the
> master will send operation status updates for the dropped operations.
> When `SchedulerDriver` frameworks set the `id` field in an offer
> operation, the master will send them a `FrameworkErrorMessage`, as
> this feature is only supported in the HTTP scheduler API.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp aa35abc53bfc34e19d19a93328fb6552b64c05d7 
> 
> 
> Diff: https://reviews.apache.org/r/63992/diff/6/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message