mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 66088: Fixed crash on macOS during certain authorization calls.
Date Thu, 15 Mar 2018 14:21:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66088/#review199258
-----------------------------------------------------------


Ship it!





src/common/http.cpp
Line 871 (original), 871 (patched)
<https://reviews.apache.org/r/66088/#comment279553>

    I'd probably add a comment saying that we have to use `set` here because we relay on the
order of the elements being well-defined below. (otherwise the next guy who sees this will
probably think "Hey, a `set`, let's change it to `hashset` for a free performance boost" ;)


- Benno Evers


On March 15, 2018, 1:59 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66088/
> -----------------------------------------------------------
> 
> (Updated March 15, 2018, 1:59 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Jan Schlicht.
> 
> 
> Bugs: MESOS-8677
>     https://issues.apache.org/jira/browse/MESOS-8677
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The method in charge of creating `ObjectApprovers` was relying that
> iterating over equivalent hashset's would yield the same order of
> results.
> 
> While that seemed to be true in different architectures, the macOS
> implementation did not follow the same pattern showing a bug in the
> code.
> 
> 
> Diffs
> -----
> 
>   src/common/http.cpp 03f539f8942d50de34f42fd711053e94d0a1c95d 
> 
> 
> Diff: https://reviews.apache.org/r/66088/diff/1/
> 
> 
> Testing
> -------
> 
> ```sh
> # In multiple platforms.
> make check
> ```
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message