mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.
Date Thu, 15 Mar 2018 14:19:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65571/
-----------------------------------------------------------

(Updated March 15, 2018, 2:19 p.m.)


Review request for mesos, Andrei Budnik and Alexander Rukletsov.


Bugs: MESOS-8550
    https://issues.apache.org/jira/browse/MESOS-8550


Repository: mesos


Description (updated)
-------

The function `MasterDetector::detect()` returns a value of type
`Future<Option<MasterInfo>>`, which, according to its documentation,
can be `None` if an election occured and no master is elected.

However, the code in `Master::detected()` was only handling the
cases of a failed future or a valid `MasterInfo` object.

*NOTE*: This commit does not add a corresponding unit test, since
that would require starting a non-leading master. For the
ZooKeeperMasterDetector, this is blocked by MESOS-2976, and an API
change to make this possible with the StandaloneMasterDetector
would add a lot of complexity to the `cluster::Master::start()`
function for a feature that is unlikely to be re-used in any other
test.


Diffs (updated)
-----

  src/master/master.cpp f0affa09dcf41b6a800e18105ad047bcffdfd3ec 


Diff: https://reviews.apache.org/r/65571/diff/4/

Changes: https://reviews.apache.org/r/65571/diff/3-4/


Testing (updated)
-------

`./mesos-tests` (See also last paragraph in description)


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message