mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sagar Patwardhan <sagar...@gmail.com>
Subject Re: Review Request 65987: Allow nested containers in pods to have separate namespaces(Ref: MESOS-8534).
Date Thu, 15 Mar 2018 04:30:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65987/
-----------------------------------------------------------

(Updated March 15, 2018, 4:30 a.m.)


Review request for mesos and Jie Yu.


Changes
-------

Added validation to disallow HTTP(s) and TCP health checks.


Bugs: MESOS-8534
    https://issues.apache.org/jira/browse/MESOS-8534


Repository: mesos


Description
-------

Continued from https://github.com/apache/mesos/pull/263


Diffs (updated)
-----

  src/master/validation.cpp f0b86775b 
  src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 1d01915c2 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 896656987 


Diff: https://reviews.apache.org/r/65987/diff/5/

Changes: https://reviews.apache.org/r/65987/diff/4-5/


Testing
-------

Manually tested.

Working on unit tests.


Thanks,

Sagar Patwardhan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message