mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66009: CMake: Added `-Wno-unused-local-typedefs` to Boost interface.
Date Wed, 14 Mar 2018 17:58:20 GMT


> On March 14, 2018, 9:38 a.m., Benjamin Bannier wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 179-182 (patched)
> > <https://reviews.apache.org/r/66009/diff/1/?file=1973217#file1973217line179>
> >
> >     Since `469363d4322c7acda7fd10acbe8822f610af5a43` we package boost-1.65.0 amd
does not appear to be needed anymore. Could you confirm that it is still needed and update
the Boost versions both here and in `configure.ac`, or alternatively drop this patch and also
remove the respective code in `configure.ac`?

Whoops, I thought I'd updated the version here. Yes, I confirmed we still needed it. Boost's
variant type is unusable without this disabled. I'll update the comments.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66009/#review199180
-----------------------------------------------------------


On March 9, 2018, 2:38 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66009/
> -----------------------------------------------------------
> 
> (Updated March 9, 2018, 2:38 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich,
Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-8658
>     https://issues.apache.org/jira/browse/MESOS-8658
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As found in the Autotools builds, GCC and Clang will emit an used
> local typedef warning for headers including Boost. Since it is
> 3rdparty code, we disable this warning in its interface.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191 
> 
> 
> Diff: https://reviews.apache.org/r/66009/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message