mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <>
Subject Re: Review Request 65954: Add a gauge for how long agent recovery takes.
Date Wed, 14 Mar 2018 16:06:20 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 14, 2018, 4:06 p.m.)

Review request for mesos, Gilbert Song, Greg Mann, Jason Lai, and James Peach.


Remove usage of atomic and rename metric.

Bugs: MESOS-8609

Repository: mesos

Description (updated)

The new metric `slave/recover_time_secs` can be used to tell us how long
Mesos agent needed to finish its recovery cycle. This is an important
metric on agent machines which have a lot of completed executor

Note that the metric 1) will only be available after recovery succeeded
and 2) never change its value across agent process lifecycle afterwards.

Diffs (updated)

  src/slave/metrics.hpp 3fc933ca65690d6fad63156398ad9c2c53789296 
  src/slave/metrics.cpp 0eb2b59ed67e14e73b29d7592c239441df0008d5 
  src/slave/slave.cpp 2f4ab157448eafc0f41372ee50255a76129e90db 





Zhitao Li

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message