mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.
Date Wed, 14 Mar 2018 15:55:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63992/#review199172
-----------------------------------------------------------



I am confused why this patch does not add a status update manager for master-generated operation
status updates. Right now there is no way for frameworks to e.g., reconcile failed operations
after framework failover since the master does not remember any operation status updates in
generated (in addition to not retrying their delivery).

Apart from that the changes seem to do what they advertise, but I wonder whether now would
be the right time to address the numerous `TOOD`s, e.g., the one about adding a helper to
encapsulate the code around `drop`ped operations. I am pretty sure this will be useful in
the future.

- Benjamin Bannier


On March 13, 2018, 10:49 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63992/
> -----------------------------------------------------------
> 
> (Updated March 13, 2018, 10:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
> 
> 
> Bugs: MESOS-8190
>     https://issues.apache.org/jira/browse/MESOS-8190
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds code to send operation status updates in the master's
> ACCEPT call handler. In cases where operations are dropped and in
> cases where offer operation IDs are set when they should not be, the
> master will send operation status updates for the dropped operations.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f 
> 
> 
> Diff: https://reviews.apache.org/r/63992/diff/5/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message