mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 65833: Displayed resource provider resources in GET_AGENTS response.
Date Wed, 14 Mar 2018 13:33:28 GMT


> On March 13, 2018, 7:07 p.m., Greg Mann wrote:
> > I'm also unable to view the protobuf utils diff in RB, strange. Unfortunately, it
looks like there is a conflict right now so I can't apply in order to view the diff either.

I have rebased the changes on a current recent master. They overlap with and depend on changes
from https://reviews.apache.org/r/65591/.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65833/#review199099
-----------------------------------------------------------


On Feb. 28, 2018, 1:55 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65833/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2018, 1:55 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8388
>     https://issues.apache.org/jira/browse/MESOS-8388
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Displayed resource provider resources in GET_AGENTS response.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto 6622e1b82861f380346f505eca326f7174dd8bd6 
>   include/mesos/v1/master/master.proto 6034bd5af8ad764f625f9fe80be08b48707bbadb 
>   src/common/protobuf_utils.cpp 9c5fb97afb58f98013b79f3cbaea7dacc3603271 
>   src/tests/api_tests.cpp e81d6ed25984c14e4143a048848c96e44e4f16e4 
> 
> 
> Diff: https://reviews.apache.org/r/65833/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message