mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 66037: Enabled agent resource provider capability by default.
Date Wed, 14 Mar 2018 13:09:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66037/
-----------------------------------------------------------

(Updated March 14, 2018, 2:09 p.m.)


Review request for mesos, Jie Yu and Jan Schlicht.


Changes
-------

Removed more now dead code.


Bugs: MESOS-8647
    https://issues.apache.org/jira/browse/MESOS-8647


Repository: mesos


Description (updated)
-------

This patch add `RESOURCE_PROVIDER` to the list of default-enabled
agent capabilities. In addition we also adjust tests to accommodate
the change in the agent registration protocol this triggers. We rely
on masters ignoring redundant `UpdateSlaveMessage`s.


Diffs (updated)
-----

  src/slave/constants.cpp 9b60bd0e808aab272039239db95bee71a3d910ab 
  src/tests/agent_resource_provider_config_api_tests.cpp bd5312b71f500a3572362a39f22d742c621762cf

  src/tests/api_tests.cpp e81d6ed25984c14e4143a048848c96e44e4f16e4 
  src/tests/master_tests.cpp 909565188afbe1398dcaa7d69d3a6872dcdcdb78 
  src/tests/oversubscription_tests.cpp 564405743cbf5805e79c04c7b37df505e988d984 
  src/tests/persistent_volume_endpoints_tests.cpp ebdc409842ce36396ce7d7bc8d45f23db1eb1973

  src/tests/persistent_volume_tests.cpp 924d8458e54e34a49c99593482b5908c5f7c7a48 
  src/tests/reservation_endpoints_tests.cpp 51146ea04fcd04efd489386be861415e2a066606 
  src/tests/reservation_tests.cpp 8d8e9c8390e65187269bd194bb322bbdff88e0bd 
  src/tests/resource_provider_manager_tests.cpp c8997ec41fe0c3e02b0f6ab205c9009205c992da 
  src/tests/slave_recovery_tests.cpp c856752fe1dc3f5b45adb21b65a736116184e10a 
  src/tests/slave_tests.cpp c2afaa573039e25fb59496765e6717e7643a692f 
  src/tests/storage_local_resource_provider_tests.cpp 264d42b57fe1a8ea04c1de0a10112878c7b45d39

  support/mesos-mini/Dockerfile f9bcdb59d233ddfa0a4523c84057c630d1d636a0 
  support/mesos-mini/mesos/agent_features.json a66852aff91e4b0c9ea996123cb6466a5ee0a050 


Diff: https://reviews.apache.org/r/66037/diff/2/

Changes: https://reviews.apache.org/r/66037/diff/1-2/


Testing
-------

`sudo make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message