mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 66015: Built CSI spec proto files with cmake.
Date Wed, 14 Mar 2018 02:57:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66015/
-----------------------------------------------------------

(Updated March 14, 2018, 2:57 a.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.


Changes
-------

Addressed Andy's comments.


Bugs: MESOS-8657
    https://issues.apache.org/jira/browse/MESOS-8657


Repository: mesos


Description
-------

Built CSI spec proto files with cmake.


Diffs (updated)
-----

  3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191 
  3rdparty/cmake/Versions.cmake 94b0d8048412e00e2480f45e7ce4e6494da4bd5d 
  src/CMakeLists.txt 0c135034982a6a4844509cd0e9b2cc41804333ef 


Diff: https://reviews.apache.org/r/66015/diff/2/

Changes: https://reviews.apache.org/r/66015/diff/1-2/


Testing
-------

`make check` with cmake.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message