-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review199128
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.cpp
Lines 5960 (patched)
<https://reviews.apache.org/r/64618/#comment279433>
Can we move this to?
`std::move(statusUuid.toBytes())`
Looks like `toBytes()` returns a `std::string` and `set_value` has an overload for rvalue
reference, so I think we can avoid a copy here if we move?
- Greg Mann
On Feb. 1, 2018, 11:52 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2018, 11:52 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
>
>
> Diffs
> -----
>
> src/master/http.cpp cf03d8bf7df583c849a3b2a326d3772820181b0f
> src/master/master.hpp 8bf2c763dafdb7df55c46a56f2ff66f2a951d947
> src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f
>
>
> Diff: https://reviews.apache.org/r/64618/diff/6/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
|