mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 63994: Added a new test for validation of offer operation IDs.
Date Tue, 13 Mar 2018 21:10:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63994/#review199119
-----------------------------------------------------------




src/tests/scheduler_tests.cpp
Lines 1080 (patched)
<https://reviews.apache.org/r/63994/#comment279429>

    I don't think we need a block for this?
    
    I'd remove this `{` and the `}` on line 1119.



src/tests/scheduler_tests.cpp
Lines 1081-1086 (patched)
<https://reviews.apache.org/r/63994/#comment279428>

    This `call` is unused and this code should be removed.



src/tests/scheduler_tests.cpp
Lines 1185 (patched)
<https://reviews.apache.org/r/63994/#comment279430>

    I'd remove these braces, unless there's a reason for this block?


- Gaston Kleiman


On March 13, 2018, 9:41 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63994/
> -----------------------------------------------------------
> 
> (Updated March 13, 2018, 9:41 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
> 
> 
> Bugs: MESOS-8190
>     https://issues.apache.org/jira/browse/MESOS-8190
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds two new scheduler tests,
> 'OperationFeedbackValidationWithResourceProviderCapability' and
> 'OperationFeedbackValidationNoResourceProviderCapability',
> to verify that task and offer operation status updates are correctly
> sent when the 'id' field is set incorrectly on an operation.
> 
> 
> Diffs
> -----
> 
>   src/tests/scheduler_tests.cpp 397a0908432ad50fa94fd939a604b096a06f8a1d 
> 
> 
> Diff: https://reviews.apache.org/r/63994/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message