mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 65851: Disallow limit in /quota requests and SET_QUOTA calls.
Date Sat, 10 Mar 2018 01:46:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65851/
-----------------------------------------------------------

(Updated March 10, 2018, 1:46 a.m.)


Review request for mesos, Michael Park and Meng Zhu.


Changes
-------

Added a TODO per meng's suggestion.


Repository: mesos


Description
-------

This ensures that after the protobuf changes to introduce limit
are committed, users cannot set limit in the existing API.


Diffs (updated)
-----

  src/master/quota.cpp 58bab6a678bac9e41a7994ba0b7cc1ed069a8a18 


Diff: https://reviews.apache.org/r/65851/diff/2/

Changes: https://reviews.apache.org/r/65851/diff/1-2/


Testing
-------

Test added in the subsequent patch.


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message