mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66002: Fixed the HTTP API path variables on Windows to use proper seperators.
Date Fri, 09 Mar 2018 19:42:44 GMT


> On March 9, 2018, 11:33 a.m., John Kordich wrote:
> > src/tests/files_tests.cpp
> > Line 338 (original), 338 (patched)
> > <https://reviews.apache.org/r/66002/diff/1/?file=1973159#file1973159line338>
> >
> >     Regarding this use of c_str():  I'm fairly certain this won't deallocate the
result of path::join("1", "2") until after the call to stat() is complete, so the string should
still be valid.  However, I'm not 100% certain, and I'd like someone else to judge this as
well.
> >     
> >     To be safe, I could allocate these paths outside of this function call, to guarantee
that this string won't be deallocated.

Yeah, it's still in scope until `stat` has returned, so it's fine. Function stacks and all.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66002/#review198955
-----------------------------------------------------------


On March 9, 2018, 11:27 a.m., John Kordich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66002/
> -----------------------------------------------------------
> 
> (Updated March 9, 2018, 11:27 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, and Joseph
Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed the HTTP API path variables on Windows to use proper seperators.
> 
> 
> Diffs
> -----
> 
>   src/files/files.cpp 5f92d2af722c3201200fa1d6a75dc0b87fdc6078 
>   src/tests/files_tests.cpp c703cae03345112715aeab83cb0a74abe3e12469 
> 
> 
> Diff: https://reviews.apache.org/r/66002/diff/1/
> 
> 
> Testing
> -------
> 
> Tested on both Windows and Linux, all tests pass, including the two newly enabled tests
on Windows.
> 
> 
> Thanks,
> 
> John Kordich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message