mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Harold Dost <h.d...@criteo.com>
Subject Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.
Date Fri, 09 Mar 2018 17:04:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66001/
-----------------------------------------------------------

Review request for mesos and James Peach.


Repository: mesos


Description
-------

New Flags for disk/xfs isolator
- xfs_disk_hard_limit_offset_pct - creates a gap between
- xfs_disk_hard_limit_offset - overrides _pct creates an offset between
  soft and hard limits of a container.
- xfs_kill_after_grace_period - will cause a container to be killed if
  the soft limit has been breached after the `xfs_quota` configured
  grace period has ended.
- xfs_kill_check_interval - Period of delay between which the isolator
  will check for violations of the soft limit.

Functionality
- Add head room to the hard limit as a percentage or specified amount
  for each container. This is specified at a flag level and not
  customizable on a per container basis.
- Provide the ability for an application to be killed after the
  configured grace period for projects is violated.
- Add an interval between which the watcher will check for violations.


Diffs
-----

  src/slave/containerizer/mesos/isolators/xfs/disk.hpp 07e68a777aefba4dd35066f2eb207bba7f199d83

  src/slave/containerizer/mesos/isolators/xfs/disk.cpp 8d9f8f846866f9de377c59cb7fb311041283ba70

  src/slave/containerizer/mesos/isolators/xfs/utils.hpp e034133629a9c1cf58b776f8da2a93421332cee0

  src/slave/containerizer/mesos/isolators/xfs/utils.cpp 2708524add1ff693b616d4fb241c4a0a3070520b

  src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e 
  src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc 


Diff: https://reviews.apache.org/r/66001/diff/1/


Testing
-------


Thanks,

Harold Dost


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message