mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 65313: Refactored authorization logic in the agent.
Date Fri, 09 Mar 2018 05:30:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65313/#review198917
-----------------------------------------------------------




src/slave/http.hpp
Line 119 (original), 119 (patched)
<https://reviews.apache.org/r/65313/#comment279184>

    const ref?



src/slave/http.hpp
Lines 230 (patched)
<https://reviews.apache.org/r/65313/#comment279200>

    I'm not completely sure what the proper capitalization would be here, but I think it should
be either `Action` or `action` instead of `ACTION`. The ObjectApprovers code uses `action`
for this case.



src/slave/http.cpp
Line 297 (original), 316 (patched)
<https://reviews.apache.org/r/65313/#comment279187>

    I think this should be indented more?



src/slave/http.cpp
Line 315 (original), 334 (patched)
<https://reviews.apache.org/r/65313/#comment279188>

    Indentation?



src/slave/http.cpp
Lines 2641-2665 (original), 2431-2469 (patched)
<https://reviews.apache.org/r/65313/#comment279202>

    Why did you opt for a new templated method instead of the pre-existing lambda, here and
elsewhere? Is it necessary because we pass the action as a template parameter?



src/slave/http.cpp
Lines 2999-3006 (original), 2810-2817 (patched)
<https://reviews.apache.org/r/65313/#comment279201>

    Not indented far enough.



src/slave/http.cpp
Line 3575 (original), 3366 (patched)
<https://reviews.apache.org/r/65313/#comment279203>

    Not indented far enough.



src/slave/slave.cpp
Lines 8376-8377 (original), 8377-8378 (patched)
<https://reviews.apache.org/r/65313/#comment279204>

    I think we can get rid of these lines?


- Greg Mann


On March 8, 2018, 12:26 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65313/
> -----------------------------------------------------------
> 
> (Updated March 8, 2018, 12:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Greg Mann.
> 
> 
> Bugs: MESOS-8434
>     https://issues.apache.org/jira/browse/MESOS-8434
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch makes uses of the new `ObjectApprovers` class which greatly
> simplifies the logic for constructing and using authorization.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.hpp c33adeb2ddd36e8be1324b3ddb1401bdf7e4e80b 
>   src/slave/http.cpp 7d7fa2b4ec2e1f8f65c5264ce72590d0d8195b9b 
>   src/slave/slave.cpp 8cb6899bf15fb697c3cb2784f63b7c2d5729d219 
> 
> 
> Diff: https://reviews.apache.org/r/65313/diff/6/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message