mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 65594: Checkpointed profiles in storage local resource provider.
Date Fri, 09 Mar 2018 01:29:57 GMT


> On Feb. 19, 2018, 3:39 p.m., Benjamin Bannier wrote:
> > src/resource_provider/state.proto
> > Lines 19 (patched)
> > <https://reviews.apache.org/r/65594/diff/3/?file=1959555#file1959555line19>
> >
> >     This file is not present for e.g., cmake builds or more generally when not building
with CSI support.

This is fixed for autotools builds. I'll file a follow-up patch for cmake builds.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65594/#review197757
-----------------------------------------------------------


On March 9, 2018, 1:29 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65594/
> -----------------------------------------------------------
> 
> (Updated March 9, 2018, 1:29 a.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8492
>     https://issues.apache.org/jira/browse/MESOS-8492
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> SLRP now checkpoints profiles associated with storage pools, and does
> not depend on the `DiskProfileAdaptor` module to return the set of
> previously-known profiles during recovery.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am f4cb731198e271b967b920235ed2785e9296f9e1 
>   src/Makefile.am 84753794eca822ab251200cccb907b328c849fb7 
>   src/resource_provider/state.proto 8577b58b8cdb63b3daddf06ea5d12f80f9d42f2b 
>   src/resource_provider/storage/provider.cpp 63dde512fd8cc9f68f5f48a96869eb09b23b6f4a

> 
> 
> Diff: https://reviews.apache.org/r/65594/diff/5/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message