mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Review Request 65975: Sequentialize reconciliations of storage pools in SLRP.
Date Thu, 08 Mar 2018 05:05:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65975/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Jie Yu, and Joseph Wu.


Bugs: MESOS-8492
    https://issues.apache.org/jira/browse/MESOS-8492


Repository: mesos


Description
-------

The storage pools needs to be reconciled in the following two scenarios:

1. When there is a change in the set of known profiles.
2. When a volume/block of an unknown profile is destroyed, because the
   disk space being freed up may belong to a known profile.

This patch adds a sequence to coordinate the reconciliations for the
above two cases.


Diffs
-----

  src/resource_provider/storage/provider.cpp 63dde512fd8cc9f68f5f48a96869eb09b23b6f4a 


Diff: https://reviews.apache.org/r/65975/diff/1/


Testing
-------

sudo make check

NOTE: `StorageLocalResourceProviderTest.ROOT_RetryOperationStatusUpdate` and `StorageLocalResourceProviderTest.ROOT_RetryOperationStatusUpdateAfterRecovery`
seems flaky. Will investigate tomorrow.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message