mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 65962: Made the default executor use references to `Owned<Container>` pointers.
Date Thu, 08 Mar 2018 03:29:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65962/#review198851
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['65692', '65693', '65694', '65695', '65962']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65962

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65962/logs/mesos-tests-stdout.log):

```

[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (51 ms)
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (58 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (112 ms total)

[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN      ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[       OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2437 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2466 ms total)

[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN      ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2454 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2481 ms total)

[----------] Global test environment tear-down
[==========] 916 tests from 91 test cases ran. (511941 ms total)
[  PASSED  ] 913 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.KillTask/0, where GetParam() = "mesos"
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0, where GetParam()
= "mesos"
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam()
= "mesos"

 3 FAILED TESTS
  YOU HAVE 210 DISABLED TESTS

```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65962/logs/mesos-tests-stderr.log):

```
I0308 03:28:53.669703  1996 master.cpp:10210] Updating the state of task 660c7063-72eb-4aac-a218-62dd4718a515
of framework c6767351-4881-42fb-9832-930b5b2bee2a-0000 (latest state: TASK_KILLED, status
update state: TASKI0308 03:28:52.950726 10868 exec.cpp:162] Version: 1.6.0
I0308 03:28:52.978703  6172 exec.cpp:236] Executor registered on agent c6767351-4881-42fb-9832-930b5b2bee2a-S0
I0308 03:28:52.983726  9212 executor.cpp:176] Received SUBSCRIBED event
I0308 03:28:52.987726  9212 executor.cpp:180] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0308 03:28:52.988725  9212 executor.cpp:176] Received LAUNCH event
I0308 03:28:52.993731  9212 executor.cpp:648] Starting task 660c7063-72eb-4aac-a218-62dd4718a515
I0308 03:28:53.073702  9212 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe
launch <POSSIBLY-SENSITIVE-DATA>'
I0308 03:28:53.618705  9212 executor.cpp:661] Forked command at 5876
I0308 03:28:53.674851  5116 exec.cpp:445] Executor asked to shutdown
I0308 03:28:53.675705  9212 executor.cpp:176] Received SHUTDOWN event
I0308 03:28:53.675705  9212 executor.cpp:758] Shutting down
I0308 03:28:53.675705  9212 executor.cpp:868] Sending SIGTERM to process tree at pid 5_KILLED)
I0308 03:28:53.669703  6528 slave.cpp:3878] Shutting down framework c6767351-4881-42fb-9832-930b5b2bee2a-0000
I0308 03:28:53.670702  6528 slave.cpp:6571] Shutting down executor '660c7063-72eb-4aac-a218-62dd4718a515'
of framework c6767351-4881-42fb-9832-930b5b2bee2a-0000 at executor(1)@10.3.1.5:55132
I0308 03:28:53.672705  6528 slave.cpp:924] Agent terminating
W0308 03:28:53.672705  6528 slave.cpp:3874] Ignoring shutdown framework c6767351-4881-42fb-9832-930b5b2bee2a-0000
because it is terminating
I0308 03:28:53.674851  1996 master.cpp:10309] Removing task 660c7063-72eb-4aac-a218-62dd4718a515
with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated:
*):[31000-32000] of framework c6767351-4881-42fb-9832-930b5b2bee2a-0000 on agent c6767351-4881-42fb-9832-930b5b2bee2a-S0
at slave(398)@10.3.1.5:55111 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0308 03:28:53.678709 10112 containerizer.cpp:2338] Destroying container 2ac36cfa-e124-4dc7-8ae7-adeeed493141
in RUNNING state
I0308 03:28:53.678709 10328 hierarchical.cpp:344] Removed framework c6767351-4881-42fb-9832-930b5b2bee2a-0000
I0308 03:28:53.679710 10112 containerizer.cpp:2952] Transitioning the state of container 2ac36cfa-e124-4dc7-8ae7-adeeed493141
from RUNNING to DESTROYING
I0308 03:28:53.679710  1996 master.cpp:1306] Agent c6767351-4881-42fb-9832-930b5b2bee2a-S0
at slave(398)@10.3.1.5:55111 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
disconnected
I0308 03:28:53.679710  1996 master.cpp:3276] Disconnecting agent c6767351-4881-42fb-9832-930b5b2bee2a-S0
at slave(398)@10.3.1.5:55111 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0308 03:28:53.679710  1996 master.cpp:3295] Deactivating agent c6767351-4881-42fb-9832-930b5b2bee2a-S0
at slave(398)@10.3.1.5:55111 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0308 03:28:53.680708  6528 hierarchical.cpp:766] Agent c6767351-4881-42fb-9832-930b5b2bee2a-S0
deactivated
I0308 03:28:53.680708 10112 launcher.cpp:156] Asked to destroy container 2ac36cfa-e124-4dc7-8ae7-adeeed493141
I0308 03:28:53.687705  1996 containerizer.cpp:2791] Container 2ac36cfa-e124-4dc7-8ae7-adeeed493141
has exited
I0308 03:28:53.726728  5024 master.cpp:1149] Master terminating
I0308 03:28:53.728739  3124 hierarchical.cpp:609] Removed agent c6767351-4881-42fb-9832-930b5b2bee2a-S0
I0308 03:28:54.373735  8864 process.cpp:929] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On March 8, 2018, 2:07 a.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65962/
> -----------------------------------------------------------
> 
> (Updated March 8, 2018, 2:07 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `Owned` pointers are copied in multiple places of the default executor.
> This violates the semantic of owned pointers and works only because
> `Owned` is currently implemented with `shared_ptr`, it'd otherwise lead
> to double-freeing the pointers.
> 
> This patch changes those places to use references to the original
> `Owned` objects instead of copies.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp 906836f3b8e0af79d7c61f90fd8a95f193b26e84 
> 
> 
> Diff: https://reviews.apache.org/r/65962/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests.sh --gtest_filter="*Default*"` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message