mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 65921: Simplified system requirements of balloon executor.
Date Tue, 06 Mar 2018 14:09:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65921/#review198692
-----------------------------------------------------------


Ship it!




Ship It!

- Till Toenshoff


On March 6, 2018, 2:07 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65921/
> -----------------------------------------------------------
> 
> (Updated March 6, 2018, 2:07 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Till Toenshoff.
> 
> 
> Bugs: MESOS-8642
>     https://issues.apache.org/jira/browse/MESOS-8642
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The ballon executor demonstrates that if memory is isolated, executors
> can get terminated should they exceed limits. For that the executor
> allocates increasing amounts of memory. To make sure that the isolator
> measurement is not skewed in the presence of swap, the executor
> additionally locks the memory to make sure all allocated memory is
> accounted for by the isolator.
> 
> Since the amount of memory a process can restricted on the system
> level with `RLIMIT_MEMLOCK`, running this example can be impossible on
> some setups.
> 
> This patch removes unneeded locking of memory on systems not using
> swap. With that this example can be run on more setups, e.g., under
> restricted accounts if no swap is used.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_executor.cpp 941cbe72f76cbd7dbf9101a409173ebe0c4108b7 
> 
> 
> Diff: https://reviews.apache.org/r/65921/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message